Recipe and documentation update for ERA5-Land.

[katjaweigel]

Before you start, please read our contribution guidelines.

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.

---

Tasks

• Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
• Give this pull request a descriptive title that can be used as a one line summary in a changelog
• Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
• Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
• Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
• Please use yamllint to check that your YAML files do not contain mistakes
• (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
• If new dependencies are introduced, check that the license is compatible with Apache2.0

New recipe/diagnostic

• Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst
• Add provenance information

Modified recipe/diagnostic

• Update documentation for the recipe to the doc/sphinx/source/recipes folder
• Update provenance information if needed
• Assign the author(s) of the affected recipe(s) as reviewer(s)

New data reformatting script

• Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
• Add the new dataset to the table in the documentation
• Tag @mattiarighi in this pull request, so that the new dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

Modified data reformatting script

• Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
• Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

---

Related to ESMValGroup/ESMValCore#879, closes core issue ESMValGroup/ESMValCore#855

[SarahAlidoost]

@katjaweigel nice work. Thank you for this contribution. I left a few comments. Please let me know if something is not clear. As a note, this PR can be merged after merging the PR in esmvalcore ESMValGroup/ESMValCore#879.

[katjaweigel]

@SarahAlidoost thanks a lot! I tried to change everything (hope I didn't miss one).

[katjaweigel]

I think this PR also has to wait for any decision in : #1909 ?

[SarahAlidoost]

I think this PR also has to wait for any decision in : #1909 ?

Thank you for addressing the comment. I left another comment about the reference tag. I think that Issue #1909 is beyond the scope of this pull request. The issue can be fixed in another PR.

[valeriupredoi]

@katjaweigel did you have time to look at @SarahAlidoost last comment please? This could be nicely merged right in time for the code freeze and make it in v2.2 👍

[katjaweigel]

@valeriupredoi and @SarahAlidoost I think I looked already at all of them, see commits on Nov 25, 2020 or did I miss something?

[valeriupredoi]

cool! @SarahAlidoost if you could approve or send more review notes that'd be awesumpossum 👍

[SarahAlidoost]

@valeriupredoi and @katjaweigel I have approved this PR.

[valeriupredoi]

not sure @valeriolucarini was tagged here 😕 Anyhoo, is this scientifically reviewed too? I think so, but need a heads up just in case, before merging. Cheers for the good work here, guys!

[valeriolucarini]

Hi, sorry - I think I missed some messages. What’s the specific point? Thanks! Valerio

…

On 17. Feb 2021, at 14:35, Valeriu Predoi ***@***.***> wrote: not sure @valeriolucarini <https://github.com/valeriolucarini> was tagged here 😕 Anyhoo, is this scientifically reviewed too? I think so, but need a heads up just in case, before merging. Cheers for the good work here, guys! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1906 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGJKEZVONHIRZ2A5WWPPLLTS7PH2PANCNFSM4UA5NN4A>.

[SarahAlidoost]

not sure @valeriolucarini was tagged here Anyhoo, is this scientifically reviewed too? I think so, but need a heads up just in case, before merging. Cheers for the good work here, guys!

sorry, my bad, I tagged the incorrect id. It is fixed now ;-)