Skip to content

switched miniconda conda setup hooks for Github Actions workflows#1913

Merged
valeriupredoi merged 1 commit intomasterfrom
switch_conda_hooks_GAtests
Nov 26, 2020
Merged

switched miniconda conda setup hooks for Github Actions workflows#1913
valeriupredoi merged 1 commit intomasterfrom
switch_conda_hooks_GAtests

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Nov 25, 2020

Mirror issue and PR of ESMValGroup/ESMValCore#873

Copy link
Member

@nielsdrost nielsdrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valeriupredoi changes look good to me. I guess we will only know the result when we merge, right?

@nielsdrost nielsdrost self-requested a review November 26, 2020 08:37
Copy link
Member

@nielsdrost nielsdrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valeriupredoi! Since this change on core seems to work just fine, let's also apply here. ESMValGroup/ESMValCore#873

@valeriupredoi
Copy link
Contributor Author

cheers @nielsdrost 🍺

@valeriupredoi valeriupredoi merged commit 92a9620 into master Nov 26, 2020
@valeriupredoi valeriupredoi deleted the switch_conda_hooks_GAtests branch November 26, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants