Restructure ClimWIP

[lukasbrunner]

The original ClimWIP recipe was growing a bit big, and for upcoming work we need to make it even bigger. Therefore, we suggest a restructuring to the following basic format. This does not modify any of the existing code, but only moves it around.

esmvaltool/
    weighting/
        climwip/
            io_functions.py
            core_functions.py
            main.py
        plot_utilities.py
        weighted_temperature_graph.py
        weighted_temperature_map.py

Tasks

• Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
• Give this pull request a descriptive title that can be used as a one line summary in a changelog
• Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
• Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
• Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
• Please use yamllint to check that your YAML files do not contain mistakes

Modified recipe/diagnostic

• Update documentation for the recipe to the doc/sphinx/source/recipes folder
• Update provenance information if needed
• Assign the author(s) of the affected recipe(s) as reviewer(s)

Closes #1918

[lukasbrunner]

This should do the trick I think @Peter9192 Do we also need a scientific review for this?

[Peter9192]

@esmvalbot please run recipe_climwip.yml

[esmvalbot]

Since @Peter9192 asked, ESMValBot will run recipe recipe_climwip.yml as soon as possible, output will be generated here

[Peter9192]

This should do the trick I think @Peter9192 Do we also need a scientific review for this?

Maybe we can both briefly inspect the output of the bot, to see if it still looks okay.
And notify @ruthlorenz that she should update the path the to climwip script in her recipe?

[Peter9192]

I updated the top post to reflect the main changes in this PR.

[esmvalbot]

ESMValBot is happy to report recipe recipe_climwip.yml ran OK, output has been generated here

[lukasbrunner]

ESMValBot is happy to report recipe recipe_climwip.yml ran OK, output has been generated here

looks identical to my output from before the changes :)

[zklaus]

There are a few outstanding code quality issues. Probably too early to merge.

[ruthlorenz]

I depend on it and its not the end of the story, there will be follow up pull requests ;-) we can deal with the codacy issues later

[zklaus]

Promise? 😛

[ruthlorenz]

if possible yes ;-)