New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on how to move code from a private repository to a public repository #1920
Documentation on how to move code from a private repository to a public repository #1920
Conversation
Have you tried building the documentation locally and checking how this contribution fits in? It renders a bit strangely for me. |
Alternatively, you can check the documentation as produced by readthedocs for this PR here. |
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
I changed the underlining for the section headings, and now the entry in the documentation is corrected. Well spotted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Would it make sense to move this content to the GitHub Workflow section? Or would that make it too hard to find and do we not like that section very much anyway anymore because it's a bit dated?
Honestly, I am not sure where I would prefer it. The GitHub Workflow section would work as well, but as you said, it is a little more hidden. And the the topic touches on both, the general contribution and the GitHub Workflow. If you think the GitHub Workflow section is anyway a little dated, then I would probably just leave the section where it is right now, and rething its placement when we update the Workflow section. |
…entation_private-repository_to_public-repository
I only have one question left: Should the steps be numbered like this? Normally, I would say that this numbering is part of the structure of the document, so if desired, should perhaps be achieved with a |
Changed the numbering from "1)" to "1." for consistency with the rest of the documentation.
Underlining of the different sections now consistent with the sections in "datasets".
I have changed the numbering and underlining so that this section of the documentation is now consistent with the numbering in the documentation section "datasets". |
Tasks
yamllint
to check that your YAML files do not contain mistakes (not necessary)Closes #1578