Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tutorial links to documentation #1927

Merged
merged 10 commits into from Dec 1, 2020

Conversation

hb326
Copy link
Contributor

@hb326 hb326 commented Nov 30, 2020

With this pull request some links to the ESMValTool tutorial are added to the documentation.

Closes #1926


Automated checks pass, status can be seen below the pull request:

  • Circle/CI tests pass. If the tests are failing, click the Details link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • The documentation is building successfully on readthedocs and looks well formatted, click the Details link to see it.

If you need help with any of the items on the checklists above, please do not hesitate to ask by commenting in the issue or pull request.

@hb326 hb326 changed the title Adding tutorial links to doumentation Adding tutorial links to documentation Nov 30, 2020
Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hb326 thanks a lot. I suggested replacing "episode" with "lesson". I think the former is a technical word, whereas the latter is more user-friendly. Also, could you please add a similar change to the part of the documentation which is about the conda installation? The related lesson can be found here. Thank you.

hb326 and others added 3 commits December 1, 2020 11:11
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@hb326
Copy link
Contributor Author

hb326 commented Dec 1, 2020

Thanks for the suggestions, @SarahAlidoost!
I have changed the wording in the two cases you suggested, and I also added the link to the Tutorial for the installation part of the documentation.

Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hb326 thank you for addressing the comments. I approved the changes.

@hb326 hb326 requested a review from axel-lauer December 1, 2020 12:13
@hb326
Copy link
Contributor Author

hb326 commented Dec 1, 2020

Hey @axel-lauer, can you merge this? Not sure if I could/should do it myself. Thanks!

@axel-lauer axel-lauer merged commit 951c0ce into master Dec 1, 2020
6 checks passed
@axel-lauer axel-lauer deleted the adding_tutorial_links_to_doumentation branch December 1, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding links to the tutorial to the documentation
4 participants