New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify installation of R development dependencies #1930
Conversation
- r-docopt | ||
- r-lintr | ||
- r-styler | ||
- r-yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's great this removes the compilation stage of these packages - will the other packages (like akima, etc) need to be compiled still? How much of a hit we're taking from extra packages in the conda env and the possibility the env will now be harder to solve? (I am not expecting an answer to the last question since that really depends on conda weather, but just a precautionary thought)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the other packages (at least the ones that are not pulled in as dependencies of these packages) will still need to be compiled. Indeed the environment will become slightly harder to solve. It would be possible to add many more R packages, because most of them are available on conda, but that would definitely make the environment harder to solve, especially when building the package from package/meta.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, it's a question of the lesser evil I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK @bouweandela I fixed the conflict and I am approving it, let's watch the GA if there's any issues with env creation after merge, I haven't actually attempted env creation myself
@jvegasbsc Any comments on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This removes the special script for installing the R dependencies needed for development and moves those to environment.yml. This is simpler to maintain and also faster because it removes the need to compile the R development dependencies.
Checklist for technical review
Automated checks pass, status can be seen below the pull request:
Details
link to find out why.Details
link to see it.