Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mlr test with solution that works for CentOS too #1936

merged 11 commits into from Dec 3, 2020


Copy link

sorry Manu man @schlunma - this fell through the cracks for a long time 馃嵑

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub.
If you are planning to modify existing functionality, please discuss it with the original author(s) by tagging them in the issue.

Before you start, please read our contribution guidelines.
To understand how we review and merge pull requests, have a look at our review guidelines.

Closes #1890

Checklist for technical review

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • The pull request has a descriptive title that can be used as a one line summary in the changelog
  • The code is composed of functions of no more than 50 lines and uses meaningful names for variables and follows the style guide
  • Documentation is available
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia). Also check that the license of the dependency you want to add and any of its dependencies are compatible with Apache2.0.

New or updated recipe/diagnostic:

  • Documentation for the recipe/diagnostic is available in the doc/sphinx/source/recipes folder and an entry has been added to index.rst
  • Provenance information has been added and no warnings related to provenance are generated when running the recipe

New or updated data reformatting script:

  • Add a new dataset to the table in the documentation
  • Add a test for the CMORized data to recipes/example/recipe_check_obs.yml and run the recipe, to make sure the CMOR checks pass without errors
  • There are clear instructions on how to obtain the data
  • Tag @remi-kazeroni in this pull request, so that the new dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

Automated checks pass, status can be seen below the pull request:

  • Circle/CI tests pass. If the tests are failing, click the Details link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • The documentation is building successfully on readthedocs and looks well formatted, click the Details link to see it.

Checklist for scientific review

New or updated recipe/diagnostic:

  • The documentation for the new/updated recipes/diagnostics clearly describes what the recipe does and how to use it
  • The recipe runs successfully on your own machine/cluster or with the @esmvalbot without any modifications to the recipe and with all data specified in the recipe
  • The figure(s) and data look as expected from the literature and/or the paper that is reproduced by the recipe
  • The code contains comments with references to formulas, figures, tables, etc. that are used from papers/online resources

New or updated data reformatting script:

  • The numbers and units of the data look physically meaningful

If you need help with any of the items on the checklists above, please do not hesitate to ask by commenting in the issue or pull request.

Copy link

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers V., great stuff! Code looks fine and the tests works on my local machine and on the CI machine 馃憤 Thanks!

@schlunma schlunma merged commit 421cd51 into master Dec 3, 2020
@schlunma schlunma deleted the fix_mlr_test_centOS branch December 3, 2020 17:55
Copy link
Contributor Author

gut gut, it's your code so if it didn't look fine I would have pointed straight at you 馃榿

@jvegreg jvegreg removed the bug label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

tests/unit/diag_scripts/mlr/ fails on select machines
4 participants