New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate classes Variable, Variables and Datasets #1944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I realized I made a mistake with the version in which to remove the feature, see also my comment in the issue.
It would probably be good to mention that the feature is deprecated and will be removed in the docstring of the affected classes too, so it becomes visible here: https://docs.esmvaltool.org/en/latest/api/esmvaltool.diag_scripts.shared.html#esmvaltool.diag_scripts.shared.Variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested it and it works as expected.
Deprecate classes
Variable
,Variables
andDatasets
.Closes #1943
Checklist for technical review
yamllint
to check that your YAML files do not contain mistakesAutomated checks pass, status can be seen below the pull request:
Details
link to find out why.Details
link to see it.