Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with bibtex references #1955

Merged
merged 6 commits into from
Dec 16, 2020
Merged

Fix issues with bibtex references #1955

merged 6 commits into from
Dec 16, 2020

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Dec 10, 2020

Hi everyone, as part of ESMValGroup/ESMValCore#901 I'm trying to render the references in a recipe using a bibtex parser. I noticed that some bibtex files have problems, either they won't parse or they won't render. This PR fixes the bibtex files so that all of them can be parsed and rendered correctly 馃憤

Closes #1954


Checklist for technical review

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • The pull request has a descriptive title that can be used as a one line summary in the changelog

Automated checks pass, status can be seen below the pull request:

  • Circle/CI tests pass. If the tests are failing, click the Details link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

@stefsmeets stefsmeets marked this pull request as ready for review December 11, 2020 15:27
Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefsmeets thank you, looks good. Just a comment about replaced article with misc in these files:

  • duemenil00mpimr
  • eyring19gmdd
  • lembo19gmdd

We ask users to use doi2bib to convert a doi to bibtex entry, see Adding references.
doi2bib shows these references as article. I am wondering why you considered them as misc.

@stefsmeets
Copy link
Contributor Author

@stefsmeets thank you, looks good. Just a comment about replaced article with misc in these files:

* duemenil00mpimr
* eyring19gmdd
* lembo19gmdd

We ask users to use doi2bib to convert a doi to bibtex entry, see Adding references.
doi2bib shows these references as article. I am wondering why you considered them as misc.

@SarahAlidoost journal is a required field for articles (see here: https://en.wikipedia.org/wiki/BibTeX#Entry_types), and these entries do not have journals. They seem to refer to datasets and preprints, none of which have a fitting entry types, so I put them as misc.

@nielsdrost nielsdrost merged commit 8960d32 into master Dec 16, 2020
@nielsdrost nielsdrost deleted the clean_bibtex branch December 16, 2020 14:57
@nielsdrost
Copy link
Member

Thanks @stefsmeets and @SarahAlidoost!

@jvegreg jvegreg added the bug label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some bibtex references generate errors
4 participants