XCH4 ESA CMUG diagnostics (subset of the MPQB diagnostics)#1960
Merged
Conversation
Adding "nh", "sh" and the correct statistics description to the provenance.
Adding "nh" and "sh" to the provenance.
Adjusting the provenance caption as suggested.
Contributor
Author
|
Contributor
|
@hb326 Thanks for working hard on this! I think most of the point I raised earlier are fine now. What I still fine a bit strange is the following in the provenance:
Other than that, I think all looks good! Nice work! |
axel-lauer
approved these changes
Jan 25, 2022
Contributor
axel-lauer
left a comment
There was a problem hiding this comment.
Receipe runs fine, documentation and output look good!
schlunma
reviewed
Jan 25, 2022
Contributor
schlunma
left a comment
There was a problem hiding this comment.
Cool stuff! 🎉
I only have minor comments regarding the documentation, commented lines and specific plot labels.
Contributor
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Removing the "esm-hist" CMIP6 simulations from the recipe.
Contributor
Author
|
You were a little quick, @axel-lauer, with the merging. :) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First diagnostic to use ESA CMUG XCH4 data for evaluating CMIP datasets.
Diagnostics are a subset of the C3S MPQB diagnostics, some with minor adjustments.
Checklist for technical review
yamllintto check that your YAML files do not contain mistakesNew or updated recipe/diagnostic:
doc/sphinx/source/recipesfolder and an entry has been added toindex.rstAutomated checks pass, status can be seen below the pull request:
Detailslink to find out why.Detailslink to see it.Checklist for scientific review
New or updated recipe/diagnostic:
@esmvalbotwithout any modifications to the recipe and with all data specified in the recipeIf you need help with any of the items on the checklists above, please do not hesitate to ask by commenting in the issue or pull request.
This pull request needs ESMValCore pull request 1428 (ESMValGroup/ESMValCore#1428) to be merged to be able to run the recipe.