Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRACE to the recipe check_obs #1963

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Dec 18, 2020

I want to add the GRACE data to the recipe_check_list as a cmorizer was developed in #1694

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic:

New or updated data reformatting script:


To help with the number pull requests:

Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. @axel-lauer what do you think?
But there is an error in the checks which you will have to fix, @remi-kazeroni, before we can merge this.

@remi-kazeroni
Copy link
Contributor Author

But there is an error in the checks which you will have to fix, @remi-kazeroni, before we can merge this.
I think I need to merge the master branch once more to pass all checks.

@remi-kazeroni
Copy link
Contributor Author

All green now but cmorizers are currently broken due to #1975. Probably better to wait for that to be fixed by #1994 to double check that the cmorizer runs and then merge this.

@bouweandela
Copy link
Member

All green now but cmorizers are currently broken due to #1975. Probably better to wait for that to be fixed by #1994 to double check that the cmorizer runs and then merge this.

Things should work just fine with the released version of ESMValCore (v2.1).

@valeriupredoi valeriupredoi merged commit b8993d9 into master Feb 4, 2021
@valeriupredoi valeriupredoi deleted the add-grace-check-obs branch February 4, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add GRACE data to recipe_check_obs
4 participants