Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes in shared functions necessary for schlund20esd #1967

Merged
merged 1 commit into from Jan 14, 2021

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Dec 23, 2020

Changes to shared modules and functions necessary for recipe_schlund20esd.yml.

The following recipes are affected:

I successfully tested all of them, but it would be nice if someone else can check recipe_ecs_constraints.yml and recipe_ecs_constraints.yml.


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic:


To help with the number pull requests:

@axel-lauer
Copy link
Contributor

I just tested recipe_cox18nature.yml and recipe_ecs_constraints.yml. Both ran successfully and the output looked fine.

@schlunma
Copy link
Contributor Author

@esmvalbot please run recipe_cox18nature.yml

@esmvalbot
Copy link

esmvalbot bot commented Jan 14, 2021

Since @schlunma asked, ESMValBot will run recipe recipe_cox18nature.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Jan 14, 2021

ESMValBot is happy to report recipe recipe_cox18nature.yml ran OK, output has been generated here

@schlunma
Copy link
Contributor Author

@nielsdrost the esmvalbot worked perfectly fine here πŸ‘

@axel-lauer I will not address the remaining Codacy issues since these would overly complicate the files. Do you approve the changes? It would be nice to get this merged soon so I can get the actual recipe for the paper in.

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@schlunma schlunma merged commit 72bdd83 into master Jan 14, 2021
@schlunma schlunma deleted the common_changes_for_schlund20esd branch January 14, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants