New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ImportError for configure_logging
#1976
Conversation
OK good catch, just gonna wait for numpy to come back then rerun the tests π |
tests are dying because of this #1980 - nothing to do with your PR, mate π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go for it, cheers for the fix!
This should only have been merged after the release of ESMValCore v2.2. Please do not merge pull requests with failing tests. If you had looked carefully through the test failures, you would have seen that this pull request introduces additional failing unit tests. |
This reverts commit 33bb6f7.
@bouweandela see me comment on the reversal PR, mate π |
This reverts commit 33bb6f7.
Sorry this was merged too early @stefsmeets, we had to revert it for now. Could you please make a new pull request with these changes? |
Thanks! |
Description
We recently moved the logging configuration to its own submodule in
esmvalcore
. This PR fixes a potentialImportError
inesmvaltool
.Before you get started
Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the π Technical or π§ͺ Scientific review.
To help with the number pull requests: