Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImportError for configure_logging #1976

Merged
merged 1 commit into from Jan 13, 2021
Merged

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Jan 13, 2021

Description

We recently moved the logging configuration to its own submodule in esmvalcore. This PR fixes a potential ImportError in esmvaltool.


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

To help with the number pull requests:

@valeriupredoi
Copy link
Contributor

OK good catch, just gonna wait for numpy to come back then rerun the tests πŸ‘

@valeriupredoi
Copy link
Contributor

tests are dying because of this #1980 - nothing to do with your PR, mate πŸ‘

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it, cheers for the fix!

@valeriupredoi valeriupredoi merged commit 33bb6f7 into master Jan 13, 2021
@valeriupredoi valeriupredoi deleted the fix_logging_import branch January 13, 2021 13:49
@bouweandela
Copy link
Member

This should only have been merged after the release of ESMValCore v2.2. Please do not merge pull requests with failing tests. If you had looked carefully through the test failures, you would have seen that this pull request introduces additional failing unit tests.

bouweandela added a commit that referenced this pull request Jan 18, 2021
@valeriupredoi
Copy link
Contributor

This should only have been merged after the release of ESMValCore v2.2. Please do not merge pull requests with failing tests. If you had looked carefully through the test failures, you would have seen that this pull request introduces additional failing unit tests.

@bouweandela see me comment on the reversal PR, mate πŸ‘

bouweandela added a commit that referenced this pull request Jan 18, 2021
@bouweandela bouweandela restored the fix_logging_import branch January 18, 2021 19:08
@bouweandela
Copy link
Member

Sorry this was merged too early @stefsmeets, we had to revert it for now. Could you please make a new pull request with these changes?

@stefsmeets
Copy link
Contributor Author

#1994

@bouweandela bouweandela deleted the fix_logging_import branch January 22, 2021 16:00
@bouweandela
Copy link
Member

Thanks!

@valeriupredoi valeriupredoi restored the fix_logging_import branch February 12, 2021 10:25
@valeriupredoi valeriupredoi deleted the fix_logging_import branch February 12, 2021 10:48
@valeriupredoi valeriupredoi restored the fix_logging_import branch February 12, 2021 11:22
@jvegreg jvegreg added the bug label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants