fix longitude in ESRL cmorizer #1988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, had to change an attribute name cause I had mistakenly added a space instead of an underscore. Will run fine until the provenance tries to do the tree diagrams, then it returns an error of "ValueError: Invalid tag name 'altitude units'". |
|
@axel-lauer Could you have a look at this? One of my IPCC figures uses data from this cmorizer so would be nice to get this fixed. Thanks in advance! |
valeriupredoi
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
@axel-lauer pls review scientifically, I had a total hard time reviewing two lines of Python from a technical perspective 😁
axel-lauer
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ongitude in ESRL cmorizer can be wrong. The table read for it uses the -180-180 range, the negative values don't get converted but just taken an absolute value of. Added 2 lines to fix this!