-
Notifications
You must be signed in to change notification settings - Fork 132
fix longitude in ESRL cmorizer #1988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Right, had to change an attribute name cause I had mistakenly added a space instead of an underscore. Will run fine until the provenance tries to do the tree diagrams, then it returns an error of "ValueError: Invalid tag name 'altitude units'". |
@axel-lauer Could you have a look at this? One of my IPCC figures uses data from this cmorizer so would be nice to get this fixed. Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axel-lauer pls review scientifically, I had a total hard time reviewing two lines of Python from a technical perspective 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this and the output looks fine. Problems with the longitude of e.g. station BRW seem fixed now.
ongitude in ESRL cmorizer can be wrong. The table read for it uses the -180-180 range, the negative values don't get converted but just taken an absolute value of. Added 2 lines to fix this!