Skip to content

fix longitude in ESRL cmorizer #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 9, 2021
Merged

fix longitude in ESRL cmorizer #1988

merged 6 commits into from
Feb 9, 2021

Conversation

bettina-gier
Copy link
Contributor

@bettina-gier bettina-gier commented Jan 15, 2021

ongitude in ESRL cmorizer can be wrong. The table read for it uses the -180-180 range, the negative values don't get converted but just taken an absolute value of. Added 2 lines to fix this!

@bettina-gier bettina-gier self-assigned this Jan 15, 2021
@bettina-gier
Copy link
Contributor Author

Right, had to change an attribute name cause I had mistakenly added a space instead of an underscore. Will run fine until the provenance tries to do the tree diagrams, then it returns an error of "ValueError: Invalid tag name 'altitude units'".
-> Changed to underscore, ready for review now!

@bettina-gier
Copy link
Contributor Author

@axel-lauer Could you have a look at this? One of my IPCC figures uses data from this cmorizer so would be nice to get this fixed. Thanks in advance!

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axel-lauer pls review scientifically, I had a total hard time reviewing two lines of Python from a technical perspective 😁

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this and the output looks fine. Problems with the longitude of e.g. station BRW seem fixed now.

@axel-lauer axel-lauer merged commit 39f1f9e into master Feb 9, 2021
@axel-lauer axel-lauer deleted the fix_ESRL-cmorizer branch February 9, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants