Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions test that runs with the latest ESMValCore master #1989

Merged
merged 20 commits into from
Jan 25, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 15, 2021

Python 3.6, 3.7 and 3.8 pass with the latest ESMValCore master picked up nightly, see results - we'll have to add Python 3.9 when we have a functional environment for ESMValTool too (we have it for Core)

EDIT: I have added Python 3.9 anyway, worst case it'll fail until we sort out the environment;
NOTE: the reason why there are so many commits is that it took me a day to realize that once you jump from one step to another, in GA, directory presence is not preserved (ie it always gets you back to the main test directory), so I tried with the new working-directory option they implemented, but that's total pish and very buggy 馃榿

@valeriupredoi
Copy link
Contributor Author

@bouweandela @nielsdrost could I get a review here chaps plese 馃嵑

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

branches:
- master
schedule:
- cron: '0 0 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to run this at 4 am instead, like the other jobs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errmm no, maybe, no...doesn't really matter coz it's not pulling the package of esmvalgroup channel - we had issues with that at exactly midnight, for some odd reason

Comment on lines +38 to +40
run: conda --version 2>&1 | tee develop_test_linux_artifacts_python_${{ matrix.python-version }}/conda_version.txt
- shell: bash -l {0}
run: python -V 2>&1 | tee develop_test_linux_artifacts_python_${{ matrix.python-version }}/python_version.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nicer to use a conda env export here instead, that would get you all the required version info to reproduce the environment locally, especially if you do it after the pip install command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is one right under it 馃榿

- shell: bash -l {0}
run: esmvaltool install R
- shell: bash -l {0}
run: esmvaltool install Julia
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm amazed this works, where do you install Julia?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't, it's pre-installed on the GA machine and trying to install it breaks things in a spectacular manner (tried that previously, kaboom-ed)

@valeriupredoi
Copy link
Contributor Author

cheers @bouweandela 馃嵑

@valeriupredoi valeriupredoi merged commit d82660a into master Jan 25, 2021
@valeriupredoi valeriupredoi deleted the ga_full_develop_test branch January 25, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants