Do not assume in save_variable that a cube with only one timestep is yearly data #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
requested changes
Feb 4, 2021
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
valeriupredoi
added
approved by technical reviewer
in scientific review
release
and removed
in technical review
labels
valeriupredoi
approved these changes
Feb 17, 2021
remi-kazeroni
approved these changes
Feb 17, 2021
remi-kazeroni
added
approved by scientific reviewer
and removed
in scientific review
labels
jvegreg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
save_variable ("esmvaltool/cmorizers/obs/utilities.py") assumes cubes with a len==1 time coordinate is yearly data. That may not be the case.
Checklist