Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new conda environment for installing ESMValTool in Docker containers #1993

Merged
merged 7 commits into from Jan 18, 2021

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jan 18, 2021

Description

Create a new conda environment to install ESMValTool in the docker containers, because updating the default conda environment leads to outdated dependencies as described in #1980.


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @bouweandela 🍺 @jvegasbsc if you're scratching yer head why I am approving a PR with almost all tests failed - that's coz they should fail given the change in esmvalcore that is now ahead of esmvaltool 👍

@bouweandela
Copy link
Member Author

The tests are mostly failing because they need #1992, could you approve that one too @valeriupredoi? Then I can merge master into this branch and hopefully everything will look green again.

@valeriupredoi
Copy link
Contributor

just did, muchacho 👍

@bouweandela bouweandela merged commit a5c3617 into master Jan 18, 2021
6 checks passed
@bouweandela bouweandela deleted the docker branch January 18, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing on Circle because the cached test code uses an ancient fiona
2 participants