Use new conda environment for installing ESMValTool in Docker containers #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
cheers @bouweandela 🍺 @jvegasbsc if you're scratching yer head why I am approving a PR with almost all tests failed - that's coz they should fail given the change in esmvalcore that is now ahead of esmvaltool 👍
|
The tests are mostly failing because they need #1992, could you approve that one too @valeriupredoi? Then I can merge master into this branch and hopefully everything will look green again. |
|
just did, muchacho 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a new conda environment to install ESMValTool in the docker containers, because updating the default conda environment leads to outdated dependencies as described in #1980.
Before you get started
Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: