New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added recipe, diagnostics and documentation for Schlund et al., ESD (2020) #2015
Conversation
@schlunma: I am giving up on trying to install ESMValCore v2.2 for testing. I'll take a look once ESMValCore v2.2 has been released and I succeed in setting up an environment again. |
Absolutely no worries @axel-lauer! I will ping you again when ESMValCore is released and #1874 is merged. |
Recipe ran fine, produces the plots from the paper, documentation clear and concise. Provenance runs correctly as well ;) My only comment would be that
this should be noted in the documentation or the header of the recipe otherwise the knowledge might get lost down the line before the issue is fixed. And from the Codacy issues, I guess you could fix this one: Also can you rerun the checks? The iris3 env is merged to master now ;) |
Co-authored-by: Bettina Gier <gier@uni-bremen.de>
Thanks for the review! π I added the caveat to the documentation. About the Codacy issue: my local |
@valeriupredoi would you have time for a brief technical review of this? The vast majority of changes are related to documentation (there's no real new diagnostic here), so this should not take long! Thanks π» |
sure, will look at it in 10min π |
@schlunma looks good, I didn't read carefully all that documentation, since I trust all is good from a scientific point (I wouldn't know that stuff anyway). Two questions: did you really want to remove the pointers to the seaborn api documentation and could you pls fix that import complaint from Codacy? πΊ |
Thanks for the review!! π
|
This PR adds the recipe, diagnostic scripts and documentation for Schlund et al., ESD (2020).
Since I used this exact code for the analysis in the paper, a thorough scientific review is not necessary. Please note that due to #1903 the recipe needs to be run with the
--check-level ignore
option.Depends on #1874.
Before you get started
Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the π Technical or π§ͺ Scientific review.
pre-commit
oryamllint
checksNew or updated recipe/diagnostic:
@esmvalbot
or some other machine without modificationTo help with the number pull requests: