Fix import of esmvalcore _logging module in cmorize_obs.py #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a duplicate of #1994 ? |
stefsmeets
approved these changes
Feb 12, 2021
|
cheers @stefsmeets 🍺 |
|
This is going to break again real soon after ESMValGroup/ESMValCore#939 |
|
If this keeps breaking, we should think about creating a proper public function for it: |
|
how do you mean? ESMValGroup/ESMValCore#939 is already merged in |
|
I thought the import moved again, but if it's fine then I said nothing 😅🤐👍 |
|
well no, the precommit hooks have nulled my change so now we're back to square A |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Github Actions are crashing with module not found error because of bad import of the new logging module in esmvalcore