Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging import in cmorize_obs again since last merge was nulled by pre-commit hooks #2022

merged 5 commits into from Feb 12, 2021


Copy link

Back to square A from #2020 because the precommit hooks have killed my change

@@ -21,7 +21,7 @@

import esmvalcore
from esmvalcore._config import read_config_user_file
from esmvalcore._logging import configure_logging
from esmvalcore._config._logging import configure_logging
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also works 👍

Suggested change
from esmvalcore._config._logging import configure_logging
from esmvalcore._config import configure_logging

@valeriupredoi valeriupredoi merged commit 4034661 into master Feb 12, 2021
@valeriupredoi valeriupredoi deleted the fix_logging_import branch February 12, 2021 13:58
Copy link

@stefsmeets When doing a technical review, please make sure that the tests pass on CircleCI before approving. This is one of the items from the checklist.

@valeriupredoi Please never merge a pull request with failing tests, you're breaking the tests for everyone that forks off from master or pulls master into their branch like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants