Fix logging import in cmorize_obs again since last merge was nulled by pre-commit hooks #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefsmeets
approved these changes
Feb 12, 2021
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| import esmvalcore | |||
| from esmvalcore._config import read_config_user_file | |||
| from esmvalcore._logging import configure_logging | |||
| from esmvalcore._config._logging import configure_logging | |||
There was a problem hiding this comment.
This also works 👍
Suggested change
| from esmvalcore._config._logging import configure_logging | |
| from esmvalcore._config import configure_logging |
|
@stefsmeets When doing a technical review, please make sure that the tests pass on CircleCI before approving. This is one of the items from the checklist. @valeriupredoi Please never merge a pull request with failing tests, you're breaking the tests for everyone that forks off from |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back to square A from #2020 because the precommit hooks have killed my change