Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda build #2026

Merged
merged 4 commits into from
Feb 16, 2021
Merged

Fix conda build #2026

merged 4 commits into from
Feb 16, 2021

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Feb 15, 2021

Description

Pinning some packages in the requirements section of the esmvaltool metapackage seems to fix the build.


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi
Copy link
Contributor

pfff no dice man, dependency error 😢

@valeriupredoi
Copy link
Contributor

I've just tried this on my machine with a miniconda 3 for Python3.9 and conflicts creep up there too, making the solving go into slow mode, at least the memory is getting shored up at about 3GB now (still high); let me see if I can pin more stuff and try again

@jvegreg
Copy link
Contributor

jvegreg commented Feb 15, 2021

I had conflicts for Python>=3.6, but succeded for python >=3.7

@bouweandela
Copy link
Member Author

Too bad it didn't work, I saw the build going past solving the esmvaltool environment without crashing, so I thought it worked, but sadly no.

@valeriupredoi
Copy link
Contributor

I had conflicts for Python>=3.6, but succeded for python >=3.7

@jvegasbsc can you commit please, we should be able to see the CI work though it, I can't get it to work no matter how many permutations I'd try on my machine and frankly am completely fed with trying 😆

@valeriupredoi
Copy link
Contributor

what a turkey - conflict again! @jvegasbsc how did you get yours to work with pinning py at 3.7?

@jvegreg
Copy link
Contributor

jvegreg commented Feb 15, 2021

what a turkey - conflict again! @jvegasbsc how did you get yours to work with pinning py at 3.7?

I also changed the version number to 2.2.0, try that

@jvegreg
Copy link
Contributor

jvegreg commented Feb 15, 2021

Also, the job will fail anyway because the tests are failing, but that should be fixed in other PR

@valeriupredoi
Copy link
Contributor

yeah I just approved #2027 where that gets fixed, I just want to see the env being solved without Exit code 137 😁

@valeriupredoi
Copy link
Contributor

@jvegasbsc you're a bloody genius! I just tested your solution with miniconda3 for Python39 (not the one labeled latest but a newer one made specifially for Python39) - and it works great 🙏 🍺

Copy link
Contributor

@jvegreg jvegreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvegasbsc 👏 🍺 and a small beer for me for identifying python as the troublemaker 😁

@valeriupredoi valeriupredoi merged commit f76e545 into master Feb 16, 2021
@valeriupredoi valeriupredoi deleted the conda-build-test2 branch February 16, 2021 09:17
@valeriupredoi
Copy link
Contributor

and the github actions are now all green and I have just got the news that my work contract has switched to permanent, good news all round 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda build is broken
3 participants