Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce python 39 in Github Actions tests #2029

Merged
merged 2 commits into from Feb 16, 2021
Merged

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Feb 16, 2021

OK gents, moving forward with Python 3.9 - introducing it as base version for them Github Action tests - good news is that the only failing test is the obviously meant to fail one, the one that installs esmvaltool from conda in a Python 3.9 environment (since we've not released and deployed the package with 3.9 yet), so please have a looksee and approve the PR, then I will proceed to removing the test branch from the workflow files and only keep master and then merge 馃憤

@valeriupredoi valeriupredoi added this to the v2.2.0 milestone Feb 16, 2021
@valeriupredoi valeriupredoi marked this pull request as ready for review February 16, 2021 11:35
Copy link
Contributor

@jvegreg jvegreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We will need another PR to remove the installation from conda using 3.7 test

@valeriupredoi
Copy link
Contributor Author

cheers Javi! good call, forgot about that 馃憤

@valeriupredoi valeriupredoi merged commit 8d74409 into master Feb 16, 2021
@valeriupredoi valeriupredoi deleted the ga_python39 branch February 16, 2021 17:02
@valeriupredoi
Copy link
Contributor Author

Nice! We will need another PR to remove the installation from conda using 3.7 test

3.6, dude! I am doing it right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants