Removed write_plots and write_netcdf in some python diagnostics

[schlunma]

This PR deprecates the options write_plots and write_netcdf for some python diagnostics (the ones I coded) and for some tests. I successfully tested all affected recipes after the change.

• Addresses Options write_plots and write_netcdf will be removed in ESMValCore v2.4 #2005

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 PR has a descriptive title for the changelog
• 🛠 Code follows the style guide
• 🛠 Documentation is available
• 🛠 YAML files pass pre-commit or yamllint checks
• 🛠 Circle/CI tests pass
• 🛠 Codacy code quality checks pass
• 🛠 Documentation builds successfully on readthedocs

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[bouweandela]

Code changes look good to me, but I do not have time to test these recipes. Do you think we could run some of them with the @esmvalbot? If not, do you think it would be OK to merge this as is, since we plan to test recipes for the release anyway?

[bouweandela]

Would it make sense to replace the word 'Deprecated' in the title with the word 'Remove'?

It would be good if you could mention in the pull request description which recipes are affected by these changes, that will make it easier to find where things went wrong if something turns out to be broken later.

[schlunma]

Code changes look good to me, but I do not have time to test these recipes. Do you think we could run some of them with the @esmvalbot? If not, do you think it would be OK to merge this as is, since we plan to test recipes for the release anyway?

I tested all recipes, but I will run some (which do not require lots of memory) with the bot. So merging should be safe.

Would it make sense to replace the word 'Deprecated' in the title with the word 'Remove'?

Done

It would be good if you could mention in the pull request description which recipes are affected by these changes, that will make it easier to find where things went wrong if something turns out to be broken later.

This is the list:

• recipe_ecs.yml
• recipe_tcr.yml
• recipe_cox18nature.yml
• recipe_flato13ipcc.yml
• recipe_schlund20jgr_*.yml

@bouweandela did you see this comment?

[schlunma]

@esmvalbot Please run recipe_cox18nature.yml

[esmvalbot]

Since @schlunma asked, ESMValBot will run recipe recipe_cox18nature.yml as soon as possible, output will be generated here

[schlunma]

@esmvalbot Please run recipe_tcr.yml

[esmvalbot]

Since @schlunma asked, ESMValBot will run recipe recipe_tcr.yml as soon as possible, output will be generated here

[schlunma]

@esmvalbot Please run recipe_ecs.yml

[esmvalbot]

Since @schlunma asked, ESMValBot will run recipe recipe_ecs.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is happy to report recipe recipe_cox18nature.yml ran OK, output has been generated here

[esmvalbot]

ESMValBot is happy to report recipe recipe_tcr.yml ran OK, output has been generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_ecs.yml: exit is 1, output has been generated here

[schlunma]

The bot failed due to missing data, but the recipe ran fine on my machine