Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flake8 raised by develop test in cmorize_obs_gpcc.py #2038

Merged
merged 1 commit into from
Feb 17, 2021
Merged

fix flake8 raised by develop test in cmorize_obs_gpcc.py #2038

merged 1 commit into from
Feb 17, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Feb 17, 2021 •
edited
Loading

This thing was not a flake8 error but a Codacy warning in the original PR, but now makes the develop test fail on master, introduced in #1995

jvegreg
jvegreg approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@jvegreg jvegreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge once test are finished

@jvegreg jvegreg merged commit f85d81a into master Feb 17, 2021
@jvegreg jvegreg deleted the fix_flake8error_in_cmorizer branch February 17, 2021 15:54
@valeriupredoi
Copy link
Contributor Author

cheers, dude! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvegreg jvegreg jvegreg approved these changes

@remi-kazeroni remi-kazeroni Awaiting requested review from remi-kazeroni

Assignees
No one assigned
Labels
bug release testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valeriupredoi @jvegreg