Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and changelog tool for v2.2.0 #2043

Merged
merged 11 commits into from
Feb 25, 2021

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Feb 18, 2021

This PR updates the changelog for v2.2.0

It also containes some updates to the script that generates the draft of the release notes and a new test to check if there are duplicated entries in the changelog

Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

@valeriupredoi
Copy link
Contributor

@jvegasbsc dude, what age was the base branch you used for this? This looks like it's from 1953 🀣

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javi man, please modernize the base branch that you use, this is before the Gulf War (first one from 1991) - we froze the code today, so grab the state of master from a75326e or something like that πŸ‘

@jvegreg
Copy link
Contributor Author

jvegreg commented Feb 19, 2021

Javi man, please modernize the base branch that you use, this is before the Gulf War (first one from 1991) - we froze the code today, so grab the state of master from a75326e or something like that πŸ‘

This was started before the core release

@jvegreg
Copy link
Contributor Author

jvegreg commented Feb 19, 2021

By thw way, I have not gone through the actual changelog, so please start reviewing only the tests and the draft tool.

@valeriupredoi
Copy link
Contributor

yeah no probs, the changelog we can go through it together next week, cheers for modernizing it 😁

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you also update the documentation on the release notes tool? https://docs.esmvaltool.org/en/latest/utils.html#draft-release-notes-py

tests/unit/test_docs.py Show resolved Hide resolved
@jvegreg
Copy link
Contributor Author

jvegreg commented Feb 25, 2021

Changelog ready!

@jvegreg jvegreg added this to the v2.2.0 milestone Feb 25, 2021
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @jvegasbsc 🍺 Did you want to add the Highlights as well as you did for the Core release or is it too pretentious given that in Tool we shouldn't be too boasty about some changes and keep others as "normal"

@jvegreg
Copy link
Contributor Author

jvegreg commented Feb 25, 2021

I added the note about Iris 3. I think we do not have any other big thing for the tool

@valeriupredoi
Copy link
Contributor

cool, that should do it πŸ‘

@jvegreg jvegreg dismissed bouweandela’s stale review February 25, 2021 13:03

I added the propossed changes

@jvegreg jvegreg merged commit a982e42 into master Feb 25, 2021
@jvegreg jvegreg deleted the update_release_notes_tool branch February 25, 2021 13:12
jvegreg pushed a commit that referenced this pull request Feb 25, 2021
* Small changes in the release notes tools

* Updated changelog and changelog tool

* use 21st century environment file

* use 21st century setup file

* Fix some codacy issues

* Small refactor

* Final version of changelog

* Add highlights

* Add last commit changelog and update tool doc

* Update doc

Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants