Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added figures 8 and 10 to recipe_bock20jgr.yml #2074

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 9, 2021

This PR adds the figures 8 and 10 of Bock et al. (2020) to the corresponding recipe.

Note:

  • For both figures, 2 CMIP6 models are missing since the data has been removed from the ESGF nodes.
  • For figure 10, I use a 5x5 grid to speed the calculation up. For the original paper, a 2x2 grid has been used.

Details:


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic:


To help with the number pull requests:

commit bb78f4fbe7c59b4de4e0ebbc2b72492ed95c7580
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Mar 8 20:30:04 2021 +0100

    Added figure 10 of bock20jgr

commit 784036e04e5d04b89d87a1c003b38e7814522135
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Mar 5 23:09:37 2021 +0100

    Fixed recipe

commit e7d334b9ea90e2d5e4f46c84529e8c3cb003473d
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Mar 5 18:26:05 2021 +0100

    Updated recipe_ecs.yml

commit 71b09d5478edaeb94c87d3fd047855e3ae53d48f
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Mar 5 18:24:06 2021 +0100

    Removed unnecessary changes

commit 8bdff6da32dd4ee4a8ed1c3198b272ac626fc3f5
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Mar 5 18:21:26 2021 +0100

    Updated bock20jgr recipe and corresponding documentation

commit d920ccbf891ba27ac85e2a600cbf66519421af75
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Mar 5 16:35:41 2021 +0100

    Removed Meehl et al. (2020) recipe and diagnostic

commit 32dc562bb0da0d7005ec8be481d06517dc74c7b4
Merge: 7392f66ba e1f91af
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Mar 5 15:56:43 2021 +0100

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit 7392f66ba43cbd4403ca72e2ac06c51a87bd4814
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Jan 13 11:20:23 2021 +0100

    Adapted seaborn settings for Meehl et al. (2020) recipe

commit 502b98ac9a47aa2012485857568dd1a16462da34
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Jan 12 18:40:58 2021 +0100

    Added option for only consider MMM in feedback parameter plots

commit ffc388db340376c29cda4eb676a230124c79d10d
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Jan 12 18:07:39 2021 +0100

    Added option to round DataFrames in create_table.py

commit 992fe32569deb2de57e1a4b69ccc56b36c780cbf
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jan 8 18:12:28 2021 +0100

    Updated recipes with new model data

commit 7c6f1606218827f8e8b1df02b40e9d6ee6bca249
Merge: e6a29c9f2 1a6e50f
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jan 8 12:41:18 2021 +0100

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit e6a29c9f2d2a34ff8366b021a24f9547fc2c22ea
Merge: 1f320aed0 a259b19
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Oct 8 13:27:58 2020 +0200

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit 1f320aed03f64cf4ea58ec07fce930d0030bb446
Merge: 6434dd6e7 71e2c72
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jul 3 10:50:23 2020 +0200

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit 6434dd6e70f2bd7825de1cf7720299623b81b454
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jul 3 10:48:44 2020 +0200

    Updated plots with new CMIP6 models

commit 4359c4939c4b8678102fc03546a030b439b977ea
Merge: e5b830c24 221f6ec
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jun 19 10:03:28 2020 +0200

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit e5b830c243cb3fa5be2e3ef7fc44f5f6eb4772ff
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Mar 19 18:21:35 2020 +0100

    Small fixes in ECS/TCR recipes and diagnostics

commit be85cef82ab98a9beb324638a0bf23f8d25f827b
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Mar 18 16:49:48 2020 +0100

    Extended ECS and TCR-related recipes and diagnostics

commit 68d5dd015810df95fd7a5ba08e9eb8d618b9676a
Merge: 4d3a0d41a 959318d
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Mar 17 10:04:55 2020 +0100

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit 4d3a0d41a1e69dcfc4121c83827897fbc33116a9
Merge: 893625c12 4b37b2e
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Feb 27 23:07:08 2020 +0100

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit 893625c1220f90378d2fb57b0d9c03861ea1c494
Merge: c00b52480 a31d0e4
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Feb 14 09:19:09 2020 +0100

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit c00b52480844f4492dc2dba1eb6cc97d71d7bf96
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Jan 13 11:26:47 2020 +0100

    Added simple diagnostic to create tables for scalar climate model data

commit 1546d97b7460336d0db93ceb92a4c4827e6a9ca3
Merge: 538f42405 33e65b8
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jan 10 17:02:43 2020 +0100

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit 538f42405b25a0e51619d80491321cb26375b46e
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jan 10 16:08:44 2020 +0100

    Added TCR vs ECS recipe

commit ed92c5c66b240679648019415d25c4e2ec7feadb
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jan 10 16:08:28 2020 +0100

    Expanded CMIP6 style file

commit 835e7153c27f18d708eb366295d03949f468ef5c
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jan 10 16:08:07 2020 +0100

    Expanded ECS and TCR diagnostics

commit 78638bd6a665501273eee096ff5b114e8b5ea324
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Jan 9 19:08:27 2020 +0100

    Added CMIP6 models to ECS/TCR diagnostics and expanded tcr.py diagnostic to accept MMM

commit 6292cde7c38e8f38a1175a1e1b3c2385bbe783c2
Merge: 53602b4a7 cbc936f
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Jan 9 12:36:21 2020 +0100

    Merge remote-tracking branch 'public/master' into version2_extend_ecs

commit 53602b4a79a3c33edf7b2389cb910a1cc72a069e
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Dec 4 16:55:32 2019 +0100

    Expaned create_barplot.py diagnostic

commit 4aae7182b423429f8b17041013f754e0439e4324
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Dec 4 10:37:54 2019 +0100

    Added possibility to ECS diagnostic to add additional attributes to output

commit 607b0106fe6ac7876e31d91dfb58636aa22b12f5
Merge: 5fd5775d3 7089a8c
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Dec 3 17:22:46 2019 +0100

    Merge remote-tracking branch 'public/fix_cox' into version2_extend_ecs

commit 5fd5775d35e44f2cc851b3c338089243cf91b030
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Dec 3 17:08:18 2019 +0100

    Removed cmip3 dataset style

commit 58fe58cad85e82419a681b85d62d80de304ad240
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Dec 3 17:00:49 2019 +0100

    Added CMIP3 models to ECS recipe

commit 05ecc38d3246c48408f19295d00a414fe1c8e67c
Merge: 47dcfd703 d0159c9
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Dec 3 13:37:20 2019 +0100

    Merge remote-tracking branch 'public/fix_cox' into version2_extend_ecs

commit 47dcfd7036f81717c84f131282543ce8ddf0f963
Merge: e49494a49 db53121
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Dec 3 13:36:50 2019 +0100

    Merge remote-tracking branch 'public/version2_development' into version2_extend_ecs

commit e49494a493f1185189c0d0e179b664a2b53ac291
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Nov 29 16:23:18 2019 +0100

    Enhanced feedback parameter plots

commit 4bd0b095d7378f2945f20603154b83acd8738aad
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Nov 29 09:52:53 2019 +0100

    Added info message when ECS calculation is not possible

commit 87587509e2d5c26580018baee9ca1df533d21b45
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Nov 29 09:50:10 2019 +0100

    Generalized function calls in main function

commit 7e4a734ba35d1835991cbc054775593fe4516e45
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Nov 28 18:08:20 2019 +0100

    Allowed calculation of multi model means for any dimension

commit 6bdcf7320d0dd68906375c406783c70584ca13f6
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Nov 27 17:19:13 2019 +0100

    Added diagnostic for calculating climate feedback parameters

commit 3535d5ecbed58afababd4049ba85b39a7005e5bf
Merge: 8b419f0af 9723c11
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Nov 27 17:08:55 2019 +0100

    Merge remote-tracking branch 'public/version2_development' into version2_extend_ecs

commit 8b419f0af401627c9ee80b7ef66408bc849ba0ad
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Sep 5 10:19:36 2019 +0200

    Adapted ECS recipe for CMIP6 models

commit 80dd68dfd644e1160fcdc868e48b593bfca45608
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jul 19 10:55:57 2019 +0200

    Improved logging messges in ECS diagnostic

commit ac9def8adcfadcb2976c9d8d2442119a3871f485
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jul 19 10:42:51 2019 +0200

    Generalized ECS recipe and diagnostic

commit 984ac1aef948c0c758eb3a21d49367d4b1818644
Merge: 04806bf84 ab639f6
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jul 19 10:28:41 2019 +0200

    Merge remote-tracking branch 'public/version2_development' into version2_extend_ecs

commit 04806bf84648dccef55abc061fb657848f54225f
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Jul 12 09:34:46 2019 +0200

    Updated ECS recipe

commit 97e8a7f8afe55016a181136b4741e040568ff400
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Jun 24 18:08:12 2019 +0200

    Fixed plot type

commit 2de63c1a98d6d90171d105fca84d0c6baae7c195
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Jun 24 18:04:41 2019 +0200

    Used fixed colormap for the map plots

commit add856bb3f4dd66edfa87905ad9e6f05094b219b
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Sun Jun 23 02:49:47 2019 +0200

    Extended ECS diagnostic to plot geographical plot

commit 40a02cedda8f7f543230768636319f6ef590cc91
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Sat Jun 22 01:23:58 2019 +0200

    Moved derived variables to core repository

commit 9dc6011c5be7f0b37c1d95b53bb3d1c8729c3c36
Merge: c27b38753 36c6a77
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Sat Jun 22 01:20:45 2019 +0200

    Merge remote-tracking branch 'public/version2_development' into version2_extend_ecs

commit c27b387535bd7c2c6ddb20caec1385d8da3aa93d
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Sat Jun 22 01:12:47 2019 +0200

    Removed CMIP6 mixes to prepare for split

commit d63f7afe679ab86810764d1d08bddf602a07371b
Merge: 47e6808ce 1d66fcc
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Sat Jun 22 01:08:28 2019 +0200

    Merge commit '1d66fccdcd6bac11bf808ca377cd356b6ca86050' into version2_extend_ecs

commit 47e6808ceafc6789a2a7cbda0510158b3c9c7f97
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Jun 5 14:18:21 2019 +0200

    Extended ECS recipe with CMIP5 models

commit 24bd5a7937973187e62a2ec98944f3cccf30cdff
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Jun 3 16:45:33 2019 +0200

    Added further models to ECS recipe

commit 0a623cbcc6d80da3da8333cfcea2a837b3021177
Merge: f9754c7fe e92fd47
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed May 29 17:29:24 2019 +0200

    Merge remote-tracking branch 'public/version2_development' into version2_extend_ecs

commit f9754c7fe55d1539a9ec88cd392c6b85455f2ce7
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed May 29 17:20:26 2019 +0200

    Extended ECS diagnostic and recipe

commit 0f51cf7d58bf57d18b5a0e87a5d2346f9175403f
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed May 29 17:16:06 2019 +0200

    Added fixes for CESM2 models

commit f8d66098e67016137555c1b6b15f9fd98908fd2b
Merge: a8b2b62c4 91fcb3b
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue May 28 14:06:08 2019 +0200

    Merge remote-tracking branch 'public/version2_development' into version2_extend_ecs

commit a8b2b62c47f114276fccdde7986590814cef77e1
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Apr 10 16:10:52 2019 +0200

    Replaced zonal mean temperature by global mean temperature

commit dde18e43ef7986134f6bed876b7c34a2e52c7d79
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Apr 10 14:40:18 2019 +0200

    Added zonal means plot to ECS diagnostic

commit 64746fbc0f25183f0a4510ccfe4a883a62852a19
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Apr 9 18:06:20 2019 +0200

    Continued implementation of zonal means (WIP)

commit 3200e90ca39838cd92a42297b5e42f7c77a8b0d0
Merge: c0b865921 7981808
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Apr 9 17:38:15 2019 +0200

    Merge branch 'version2_diag_scripts_shared_tests' into version2_extend_ecs

commit c0b8659211fc4b7de97d6a8371347d32c4248e91
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Apr 8 16:05:13 2019 +0200

    Extended ECS recipe and diagnostic

commit f5815c41f8892c09a553fb51c702fedf446d2af9
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Sun Apr 7 18:53:11 2019 +0200

    Finished implementation of tests

commit 4557e92571aa8af8302abcfb70bcdef194286d2a
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Sat Apr 6 17:54:12 2019 +0200

    Implemented further tests for iris_helpers functions

commit e1b0e5690131be66b4ec1f6c05d43dc0ab0a6cec
Merge: cd6cf583c dcc8023
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Apr 5 17:56:28 2019 +0200

    Merge remote-tracking branch 'public/version2_development' into version2_extend_ecs

commit cd6cf583ce8d2181838f909c095f70459c159338
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Fri Apr 5 17:53:36 2019 +0200

    Finished units tests for io and started implementation of tests for iris_helpers

commit 7357939
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Apr 4 18:15:23 2019 +0200

    Added first unit tests for io module for shared diagnostics

commit 5d3d7a6
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Apr 4 18:14:21 2019 +0200

    Fixed bug in io function where standard_name was not correctly set

commit 5fcbe06
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Apr 4 15:42:28 2019 +0200

    Generalized unify_1d_coord function

commit 79747a3
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Apr 4 14:56:57 2019 +0200

    Generalized iris helper functions

commit b061f8f
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Apr 4 14:51:22 2019 +0200

    Generalized grid correction in variable derivation

commit 34d6720
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Apr 4 14:17:13 2019 +0200

    Added fixes for various models

commit da130f9
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Apr 4 14:02:37 2019 +0200

    Renamed iris save function in io module

commit fb0517f
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Thu Apr 4 13:43:22 2019 +0200

    Added provenance for summary table

commit cb65c9a
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Apr 3 17:57:58 2019 +0200

    Fixed codacy issue

commit 2d25604
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Wed Apr 3 17:13:53 2019 +0200

    Added summary table to ECS diagnostic

commit 3bd6b35
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Apr 2 17:30:39 2019 +0200

    Extended ECS diagnostic for further feedback parameters

commit b5bc71e
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Apr 2 17:28:12 2019 +0200

    Variable renaming in diagnostics

commit 1437d65
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Apr 2 17:24:31 2019 +0200

    Fixed small bug which prevented setting standard_names of cubes

commit 7554421
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Apr 2 17:16:39 2019 +0200

    Added new derived radiation variables

commit e354c60
Merge: 120aa90 f8f8267
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Tue Apr 2 10:12:28 2019 +0200

    Merge remote-tracking branch 'public/version2_development' into version2_fix_ecs

commit 120aa90
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Mar 4 11:37:09 2019 +0100

    Fixed small bug in ecs_regression function

commit 2c12d9a
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Mar 4 10:10:56 2019 +0100

    Adapted y axis range in ECS regression plot

commit 47201e6
Author: Manuel Schlund <manuel.schlund@dlr.de>
Date:   Mon Mar 4 10:27:13 2019 +0100

    Improved ECS calculation and added more complex plots
@schlunma schlunma self-assigned this Mar 9, 2021
@schlunma
Copy link
Contributor Author

schlunma commented Mar 9, 2021

The remaining Codacy issues will not be fixed (would not improved the code).

@schlunma
Copy link
Contributor Author

schlunma commented Mar 9, 2021

@esmvalbot Please run recipe_ecs.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 9, 2021

Since @schlunma asked, ESMValBot will run recipe recipe_ecs.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 9, 2021

ESMValBot is happy to report recipe recipe_ecs.yml ran OK, output has been generated here

@schlunma
Copy link
Contributor Author

schlunma commented Mar 9, 2021

@esmvalbot Please run recipe_cox18nature.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 9, 2021

Since @schlunma asked, ESMValBot will run recipe recipe_cox18nature.yml as soon as possible, output will be generated here

@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 9, 2021
@ESMValGroup ESMValGroup deleted a comment from esmvalbot bot Mar 9, 2021
@esmvalbot
Copy link

esmvalbot bot commented Mar 9, 2021

ESMValBot is happy to report recipe recipe_cox18nature.yml ran OK, output has been generated here

@axel-lauer
Copy link
Contributor

@esmvalbot Please run recipe_bock20jgr.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 9, 2021

Since @axel-lauer asked, ESMValBot will run recipe recipe_bock20jgr.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 9, 2021

ESMValBot is sorry to report it failed to run recipe recipe_bock20jgr.yml: exit is 1, output has been generated here

@schlunma
Copy link
Contributor Author

I will remove the missing models for figure 8 and 10 and comment out the remaining figures for the test.

@schlunma
Copy link
Contributor Author

@esmvalbot Please run recipe_bock20jgr_TEST_DO_NOT_MERGE.yml

@esmvalbot
Copy link

esmvalbot bot commented Mar 10, 2021

Since @schlunma asked, ESMValBot will run recipe recipe_bock20jgr_TEST_DO_NOT_MERGE.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Mar 10, 2021

ESMValBot is sorry to report it failed to run recipe recipe_bock20jgr_TEST_DO_NOT_MERGE.yml: exit is 1, output has been generated here

@schlunma
Copy link
Contributor Author

I guess the bot ran out of memory for figure 10 πŸ˜•

@nielsdrost
Copy link
Member

Hi @schlunma, actually, it ran out of disk space :-(

@axel-lauer
Copy link
Contributor

I am currently running recipe_bock20jgr.yml on Mistral. Output for figures 1, 2, 3, 4 and 8 looks good. Figure 10 is not finished yet...

@nielsdrost
Copy link
Member

Hi @schlunma, actually, it ran out of disk space :-(

I'll request a larger disk for the bot...

@schlunma
Copy link
Contributor Author

Hi @schlunma, actually, it ran out of disk space :-(

Yeah, this recipe produces a lot of intermediate files in the preproc dir, the actual output should not be a problem.

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran recipe_bock20jgr.yml and the output looks fine (I had to remove the CMIP5 model CESM1-CAM5-1-FV2 because of missing data). The output of figure 10 is on a coarser grid (5x5 instead of 2x2 as in the orignal paper) but from a scientific point of view this is fine. This could either be reverted to 2x2 degree or alternatively simply mentioned in the documentation to prevent surprises.

Please do not forget to remove recipe_bock20jgr_TEST_DO_NOT_MERGE.yml before merging.

@schlunma
Copy link
Contributor Author

Great, thanks for reviewing Axel! I added a note to the documentation and removed the test recipe.

@LisaBock
Copy link
Contributor

Thanks, Manuel, for adding the figures! And thanks, Axel, for reviewing!

@axel-lauer axel-lauer merged commit 510b0e8 into master Mar 15, 2021
@axel-lauer axel-lauer deleted the bock20jgr_figs_8_10 branch March 15, 2021 08:29
mo-tgeddes added a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add figures 8 and 10 to recipe_bock20jgr
4 participants