Move private _(global)_stock_cube from esmvacore.preprocessor._regrid to cmorizer#2087
Merged
valeriupredoi merged 3 commits intomasterfrom Mar 19, 2021
Merged
Conversation
Contributor
Author
|
can I pls get an OK for this one guys, tests are failing coz of the need for this 👍 🍺 |
Contributor
|
Code looks good (I guess you just copy-pasted from ESMValCore, right?)! But it probably wouldn't hurt to test the output of the CMORizer and compare it to the old version. I will do that briefly! |
Contributor
Author
|
many thanks, Manu 🍺 |
schlunma
approved these changes
Mar 19, 2021
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
I had to fix the CMORizer because of a
iris.exceptions.UnitConversionError: Cannot convert from unknown units. The "cube.units" attribute may be set directly.
but the output is identical to the data we have stored on mistral (I only checked the years 1961 and 1962 though to save computation time) 👍
Contributor
Author
|
@schlunma you a total trooper, cheers bro! 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private import and on top of it all, func changed name from
_stock_cubeto_global_stock_cube. A bit clunky since I had to move a host of global variables but heyho, more secure now.