Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip recipe filler tests until we have a new release since GA tests are failing #2089

Merged
merged 2 commits into from Mar 18, 2021

Conversation

valeriupredoi
Copy link
Contributor

Since the GA development tests are using the latest esmvalcore development branch, and the recipe filler is configured for the (lagging behind) release, GA full development tests are failing, that, in turn, may mask an issue with the latest esmvalcore development branch + esmvaltool. Discussed with @schlunma in #2088 馃憤 We'll have to reactivate them when we release esmvalcore 2.3.0 and change the setup in the recipe filler to use the new config module

Closes #2088

@schlunma
Copy link
Contributor

Nice one! Two suggestions:

  1. Would it make sense to use skipif with version.parse(esmvalcore.__version__) < version.parse(2.3.0) using packaging.version.parse so we are reminded to fix the test for the new release?
  2. Can you skip the other two fails too:
==================================== ERRORS ====================================
______ ERROR collecting esmvaltool/cmorizers/obs/cmorize_obs_cds_uerra.py ______
esmvaltool/cmorizers/obs/cmorize_obs_cds_uerra.py:45: in <module>
    from esmvalcore.preprocessor._regrid import _stock_cube
E   ImportError: cannot import name '_stock_cube' from 'esmvalcore.preprocessor._regrid' (/home/runner/work/ESMValTool/ESMValCore/esmvalcore/preprocessor/_regrid.py)
______ ERROR collecting esmvaltool/cmorizers/obs/cmorize_obs_cds_uerra.py ______
esmvaltool/cmorizers/obs/cmorize_obs_cds_uerra.py:45: in <module>
    from esmvalcore.preprocessor._regrid import _stock_cube
E   ImportError: cannot import name '_stock_cube' from 'esmvalcore.preprocessor._regrid' (/home/runner/work/ESMValTool/ESMValCore/esmvalcore/preprocessor/_regrid.py)

@valeriupredoi
Copy link
Contributor Author

cheers Manu, good point! for 1. I am going to plug the skip now, for 2. I moved the private import via drag and dropping the functions in #2087

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 馃嵑

@valeriupredoi
Copy link
Contributor Author

danke sehr, Herr Doktor Manu 馃榿

@valeriupredoi valeriupredoi merged commit be90d4b into master Mar 18, 2021
@valeriupredoi valeriupredoi deleted the skip_recipe_filler_tests_til_new_release branch March 18, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action tests fail
2 participants