CMORizer for CLARA-AVHRR cloud data #2101
Conversation
There was a problem hiding this comment.
Hi @axel-lauer although I'm not well versed in NCL, I had a go at doing a tech review for this PR. So I just ask a couple of questions to verify I understand the code correctly.
I can tick all tech review boxes since the docs are okay and the variable has been added. It would be good if the scientific reviewer is extra keen on verifying that the output data also makes sense.
|
All changes discussed above have been implemented with commit a755bca. |
|
cheers @axel-lauer - since I don't speak NCL, I'll let Peter and Remi green flag this PR, one prickly point though - please tick or remove all boxes in the PR description (the units one is left unchecked) 馃嵑 |
|
@valeriupredoi thanks for taking a look! Just checked the last box. |
|
yay! if @remi-kazeroni would find a bit of time to run this then I can merge today 馃嵑 |
There was a problem hiding this comment.
The cmorizer script runs fine for me but the recipe_check_obs,yml does not. It seems that different variable names (lwp, clwvi) are used. Could you please clarify that @axel-lauer?
There was a problem hiding this comment.
Thanks @axel-lauer! This looks ready to be merged. May I let you put the cmorized data into the OBS directory?
|
@remi-kazeroni Thanks! Yes, I'll put the cmorized data into our OBS directory. |
|
@axel-lauer is this good to be merged or do you think another more scientific review is needed here? |
|
I think this is ready to be merged. |
This PR add a CMORizer script for the CLARA-AVHRR cloud dataset (variables clt, clivi, clwvi) from the Satellite Application Facility on Climate Monitoring (CM SAF).
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.
New or updated data reformatting script