Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for ERA5 with new variables #2111

Merged
merged 5 commits into from
Apr 14, 2021

Conversation

lukasbrunner
Copy link
Contributor

@lukasbrunner lukasbrunner commented Mar 30, 2021

Description

As discussed in #2097 some variables were added to the on-the-fly fixes for ERA5 data. This PR updates the documentation acordingly.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


@lukasbrunner lukasbrunner self-assigned this Mar 30, 2021
@lukasbrunner
Copy link
Contributor Author

Okay how does this look? Apart from the fact that I obviously have no idea how internal links work... I found it important to mention that the upward radiation variables are calculated on the fly so they are available even though they are not in the input data repository.

@Peter9192
Copy link
Contributor

Hmm, that double asterix doesn't seem to work if you look at the docs preview (you can find it if you click the details on the github check for docs). Maybe we can use labelled footnotes instead? That would look something like:

[#note1]_ and [#note2]_ in conjunction with

.. [#note1] ERA5 cmorization is built into ...
.. [#note2] Derived on the fly from down & net radiation

@lukasbrunner
Copy link
Contributor Author

Okay that worked thanks are you happy with that @Peter9192 ?

@lukasbrunner lukasbrunner marked this pull request as ready for review April 5, 2021 15:26
Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks find with me. Thanks for picking that up :-)

@nielsdrost
Copy link
Member

Thanks @Peter9192 and @lukasbrunner!

@nielsdrost nielsdrost merged commit 0dd6fc1 into master Apr 14, 2021
@nielsdrost nielsdrost deleted the update_documentation_era5 branch April 14, 2021 17:40
@zklaus zklaus changed the title Update documentation for ERA5 with new varibles Update documentation for ERA5 with new variables Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation era5 EUCP www.eucp-project.eu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for Supported datasets/ERA5
3 participants