Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try mamba install esmvaltool #2125

Merged
merged 2 commits into from May 4, 2021
Merged

try mamba install esmvaltool #2125

merged 2 commits into from May 4, 2021

Conversation

valeriupredoi
Copy link
Contributor

To speedup the installation from conda - trying using mamba install

@valeriupredoi
Copy link
Contributor Author

well I'll be a donkey and a half! Look at the speedup! And contrary to what I found locally, all goes well 😮

Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the order of the channels here is esmvalgroup,conda-forge. Could that mean that this picks up the esmvalcore from our own channel (which has cython as a dependency itself), instead of the conda-forge one?

@@ -34,7 +35,9 @@ jobs:
- shell: bash -l {0}
run: python -V 2>&1 | tee conda_install_linux_artifacts_python_${{ matrix.python-version }}/python_version.txt
- shell: bash -l {0}
run: conda install esmvaltool 2>&1 | tee conda_install_linux_artifacts_python_${{ matrix.python-version }}/install.txt
run: conda install mamba
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mamba suggests to install mamba in -n base. Do you want to avoid that on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but the environment gets created at the top of the Github Action job, exiting it to stay in base then re-entering it is a bit sillyo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the order of the channels here is esmvalgroup,conda-forge. Could that mean that this picks up the esmvalcore from our own channel (which has cython as a dependency itself), instead of the conda-forge one?

indeed it could be that but not 100% sure since we're not setting channel priority to strict, but now you've fixed it on conda-forge so it should be all the same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but the environment gets created at the top of the Github Action job, exiting it to stay in base then re-entering it is a bit sillyo

I don't think you need to do that. Just add -n base to the command line.

@Peter9192 Peter9192 mentioned this pull request Apr 23, 2021
@@ -34,7 +35,9 @@ jobs:
- shell: bash -l {0}
run: python -V 2>&1 | tee conda_install_linux_artifacts_python_${{ matrix.python-version }}/python_version.txt
- shell: bash -l {0}
run: conda install esmvaltool 2>&1 | tee conda_install_linux_artifacts_python_${{ matrix.python-version }}/install.txt
run: conda install mamba
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but the environment gets created at the top of the Github Action job, exiting it to stay in base then re-entering it is a bit sillyo

I don't think you need to do that. Just add -n base to the command line.

@valeriupredoi
Copy link
Contributor Author

cheers @zklaus 🍺

@valeriupredoi valeriupredoi merged commit b78572c into master May 4, 2021
@valeriupredoi valeriupredoi deleted the try_mamba branch May 4, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants