Update use of fx vars to new syntax #2145
Merged
valeriupredoi merged 1 commit intomasterfrom Apr 30, 2021
Merged
Conversation
valeriupredoi
approved these changes
Apr 30, 2021
Contributor
valeriupredoi
left a comment
There was a problem hiding this comment.
thanks lots @sloosvel 🍺 Am surprised this is the only use of fx_variables in a recipe (did grep it myself) 😁
Contributor
Author
|
I was surprised too! But shouldn't this be merged after ESMValGroup/ESMValCore#999 ? I think the recipe and cmorizers will break otherwise, with the change in the interface. |
Contributor
|
indeed - thought that was merged already! Heck, am going straight there now 😁 |
Contributor
|
also, this would break the recipe anyway in user-mode since the released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes in ESMValTool recipes and scripts due to ESMValGroup/ESMValCore#999
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
New or updated data reformatting script
To help with the number of pull requests: