Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of fx vars to new syntax #2145

Merged
merged 1 commit into from Apr 30, 2021
Merged

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Apr 29, 2021

Description

Changes in ESMValTool recipes and scripts due to ESMValGroup/ESMValCore#999


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script


To help with the number of pull requests:

@sloosvel sloosvel marked this pull request as ready for review April 30, 2021 07:21
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks lots @sloosvel 🍺 Am surprised this is the only use of fx_variables in a recipe (did grep it myself) 😁

@valeriupredoi valeriupredoi merged commit 7652152 into master Apr 30, 2021
@valeriupredoi valeriupredoi deleted the dev_update_fx_vars branch April 30, 2021 11:53
@sloosvel
Copy link
Contributor Author

I was surprised too! But shouldn't this be merged after ESMValGroup/ESMValCore#999 ? I think the recipe and cmorizers will break otherwise, with the change in the interface.

@valeriupredoi
Copy link
Contributor

indeed - thought that was merged already! Heck, am going straight there now 😁

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Apr 30, 2021

also, this would break the recipe anyway in user-mode since the released esmvalcore will be behind until the next release, but I am not a fan of postponing PRs til release of a dep - I know @bouweandela is 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating recipes/diags to use the new interface for fx variables
2 participants