Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin on esmvalcore pick up esmvalcore=2.3.0 #2200

Merged
merged 18 commits into from Jun 18, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jun 16, 2021

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number of pull requests:

Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Just please do the checklist!

@valeriupredoi
Copy link
Contributor Author

Great, thanks! Just please do the checklist!

shall do, boss! Just waiting on the tests πŸ‘

@valeriupredoi
Copy link
Contributor Author

conda build running out of resident memory again and the other tests taking an eternity, might be finished by the time Wales-Turkey game starts 🏴󠁧󠁒󠁷󠁬󠁳󠁿 - πŸ‡ΉπŸ‡· I'll try rerun the conda build test again, hopefully it was a fluke, but if it's persistent we'll just have to merge this and deal with it separately

@valeriupredoi
Copy link
Contributor Author

looking into conda build consuming copious amounts of memory now

@schlunma schlunma mentioned this pull request Jun 17, 2021
17 tasks
@valeriupredoi
Copy link
Contributor Author

OK - tests pass, env gets created, etc etc (and I pinned Matplotlib due to conflicts with nc-time-axis, see above) - only thing that is a showstopper is (again) conda-build that's going through the roof on memory - I ran some local tests and can't throttle the memory just yet, @zklaus you OK to merge this now and I'll keep working on the conda-build memory sink? I think this is starting to be needed by others

@zklaus
Copy link
Contributor

zklaus commented Jun 18, 2021

Yes, I am ok with that.

@valeriupredoi
Copy link
Contributor Author

hang on I think I've fixed it

@zklaus
Copy link
Contributor

zklaus commented Jun 18, 2021

If you want to experiment, that's fine, but I am not prepared to leave Python 3.8 behind just yet. In fact, I am not completely sure about Python 3.7, but that might be ok. All in all, if the problem really is only with the conda-build, I would highly recommend to merge this PR soon, preferably with Python>=3.7, and continue any necessary work on the conda-build separately.

@valeriupredoi
Copy link
Contributor Author

I will right after the test (hopefully) passes, then I will revert back to 3.7 and merge, gimme 10min max, man

@zklaus
Copy link
Contributor

zklaus commented Jun 18, 2021

Start the clock πŸ‘…

@valeriupredoi
Copy link
Contributor Author

OK Ive reverted the test bits (looks like with Python 3.9 only conda build goes on w/o memory issues) - waiting for all tests bar conda build to finish and then immediately merge

@valeriupredoi valeriupredoi merged commit 1595275 into main Jun 18, 2021
@valeriupredoi valeriupredoi deleted the update_pin_esmvalcore branch June 18, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ESMValCore pin to new release
2 participants