Update pin on esmvalcore pick up esmvalcore=2.3.0#2200
Conversation
zklaus
left a comment
There was a problem hiding this comment.
Great, thanks! Just please do the checklist!
shall do, boss! Just waiting on the tests 👍 |
|
conda build running out of resident memory again and the other tests taking an eternity, might be finished by the time Wales-Turkey game starts 🏴 - 🇹🇷 I'll try rerun the conda build test again, hopefully it was a fluke, but if it's persistent we'll just have to merge this and deal with it separately |
|
looking into conda build consuming copious amounts of memory now |
|
OK - tests pass, env gets created, etc etc (and I pinned Matplotlib due to conflicts with nc-time-axis, see above) - only thing that is a showstopper is (again) conda-build that's going through the roof on memory - I ran some local tests and can't throttle the memory just yet, @zklaus you OK to merge this now and I'll keep working on the conda-build memory sink? I think this is starting to be needed by others |
|
Yes, I am ok with that. |
|
hang on I think I've fixed it |
|
If you want to experiment, that's fine, but I am not prepared to leave Python 3.8 behind just yet. In fact, I am not completely sure about Python 3.7, but that might be ok. All in all, if the problem really is only with the conda-build, I would highly recommend to merge this PR soon, preferably with Python>=3.7, and continue any necessary work on the conda-build separately. |
|
I will right after the test (hopefully) passes, then I will revert back to 3.7 and merge, gimme 10min max, man |
|
Start the clock 👅 |
|
OK Ive reverted the test bits (looks like with Python 3.9 only conda build goes on w/o memory issues) - waiting for all tests bar conda build to finish and then immediately merge |
Description
matplotlibto an older version andnc-time-axisrestricted to not be1.3.1(even if that's currently impossible to be installed withirisas explained in this issue nc-time-axis==1.3.1 impossible to install with scitools-iris==3.0.2 SciTools/nc-time-axis#71 - the newnc-time-axismay be resolvable in the future withiris, but the plotting issue may still persist)setup.pytoflake-8-ignorelistBefore you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: