Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cmorizer utils funcs public in utilities.py and add some numpy style docstrings #2206

Merged
merged 5 commits into from
Jun 25, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jun 25, 2021

Description

Make all funcs from utilities.py public (100% now) to be used widely and have API documentation for them (not fully covered at the mo).


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number of pull requests:

@bouweandela bouweandela changed the title Make cmorizer utils funcs public in utilities.py and add some numy docs Make cmorizer utils funcs public in utilities.py and add some numpy docs Jun 25, 2021
@bouweandela bouweandela changed the title Make cmorizer utils funcs public in utilities.py and add some numpy docs Make cmorizer utils funcs public in utilities.py and add some numpy style docstrings Jun 25, 2021
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I guess #1657 is going to be bumped to the next release again?

@valeriupredoi
Copy link
Contributor Author

cheers @bouweandela - I am guessing so πŸ‘€

@valeriupredoi valeriupredoi merged commit 18e3fce into main Jun 25, 2021
@valeriupredoi valeriupredoi deleted the make_cmorizer_utils_funcs_public branch June 25, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all functions from cmorizers/obs/utilities.py public
2 participants