Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Python to 3.9 for development installation #2208

Merged
merged 1 commit into from Jun 25, 2021
Merged

Pin Python to 3.9 for development installation #2208

merged 1 commit into from Jun 25, 2021

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jun 25, 2021

Description

Make the development installation faster by using Python 3.9.

This pull request does not attempt to fix the conda build.

Related to #2150


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number of pull requests:

@valeriupredoi
Copy link
Contributor

I don't think we need this Bouwe man, I fixed it with mamba in #2205 and it's not needing Python 3.9 there. We will have to use 3.9 for conda build though

@valeriupredoi
Copy link
Contributor

mamba makes the develop test run 3min faster too πŸ˜†

@bouweandela
Copy link
Member Author

Yes, I saw. I like mamba, but the question that is still unanswered for me is whether or not mamba is mature enough #2150 (comment). Also, if we decide to switch to mamba, we should do so everywhere in the documentation and tests for a consistent user experience, not just here and there when we need it.

@valeriupredoi
Copy link
Contributor

yeah that's a very good point about consistency, note that we're already using mamba in the GA test to install from conda (no way we could do it without it for all the older Pythons) and we'll be using it for the conda lock creation too (and it works very well too) so how about we go with this approach now then we put mamba through the paces and adopt it universally for the next release?

# conda env update >> /logs/conda.txt 2>&1
conda env create -n esmvaltool -f environment.yml >> /logs/conda.txt 2>&1
conda create --name esmvaltool 'python=3.9' >> /logs/conda.txt 2>&1
conda env update --name esmvaltool >> /logs/conda.txt 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, good move, just as conda incubator does on the GA test πŸ‘

conda env create --name esmvaltool --file environment.yml
conda create --name esmvaltool 'python=3.9'

if needed, older versions of Python can also be selected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a note that env will might not solve for older versions (the GA still works but not sure how long til it'll break)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address the problem when it arises

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@bouweandela bouweandela merged commit 7184f3d into main Jun 25, 2021
@bouweandela bouweandela deleted the install branch June 25, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants