Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mpich to avoid default install of 3.4.1 and 3.4.2 with external_0 builds #2220

Merged
merged 5 commits into from
Jul 2, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jul 2, 2021

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number of pull requests:

setup.py Outdated
'matplotlib>3.3.1,<3.4', # bug in 3.3.1, issue with nc-time-axis for >3.3.4
'natsort',
'nc-time-axis<1.3.1', # needed by iris.plot, issues with matplotlib 3.4 and 1.3.1
'netCDF4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove netCDF4? I mean, it kind of makes sense, but I want to understand if it is necessary to make things work and why for future knowledge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crap, my bad!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. As a dependency of a dependency, it should probably not be here, but let's make this kind of change later on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed! let's get this in so Manu can run his shtuff 😁

@valeriupredoi
Copy link
Contributor Author

cheers @zklaus 🍺 I'll fix those boxes now

@zklaus
Copy link
Contributor

zklaus commented Jul 2, 2021

You know me so well πŸ˜„

@valeriupredoi valeriupredoi merged commit c528bee into main Jul 2, 2021
@valeriupredoi valeriupredoi deleted the pin_mpich branch July 2, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESMValTool installed in development mode does not run
2 participants