Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ClimWIP basic test recipe when plotting #2225

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

lukasbrunner
Copy link
Contributor

@lukasbrunner lukasbrunner commented Jul 6, 2021

Description

This updates the recipe to fix a bug in plotting as described in #2224.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@lukasbrunner lukasbrunner self-assigned this Jul 6, 2021
@lukasbrunner lukasbrunner added the EUCP www.eucp-project.eu label Jul 6, 2021
@lukasbrunner lukasbrunner marked this pull request as ready for review July 6, 2021 13:01
@lukasbrunner lukasbrunner requested review from bouweandela and removed request for ruthlorenz July 7, 2021 06:40
@lukasbrunner lukasbrunner added this to the [locked] v2.3.0 milestone Jul 7, 2021
@lukasbrunner lukasbrunner requested a review from zklaus July 7, 2021 06:41
@bouweandela
Copy link
Member

@esmvalbot Please run recipe_climwip_test_basic.yml

@esmvalbot
Copy link

esmvalbot bot commented Jul 8, 2021

Since @bouweandela asked, ESMValBot will run recipe recipe_climwip_test_basic.yml as soon as possible, output will be generated here

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@esmvalbot
Copy link

esmvalbot bot commented Jul 11, 2021

ESMValBot is sorry to report it failed to run recipe recipe_climwip_test_basic.yml: exit is 255, output has been generated here

@bouweandela
Copy link
Member

@esmvalbot Please run recipe_climwip_test_basic.yml

@esmvalbot
Copy link

esmvalbot bot commented Jul 11, 2021

Since @bouweandela asked, ESMValBot will run recipe recipe_climwip_test_basic.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Jul 11, 2021

ESMValBot is happy to report recipe recipe_climwip_test_basic.yml ran OK, output has been generated here

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can vouch for the scientific quality as well for this recipe. Let's merge it πŸ‘

@zklaus zklaus merged commit 763ba54 into main Jul 12, 2021
@zklaus zklaus deleted the fix_bug_climwip_test_basic branch July 12, 2021 09:36
@zklaus zklaus added the bug label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug EUCP www.eucp-project.eu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in ploting routines for ClimWIP test recipes
4 participants