Fix bug in ClimWIP brunner19 recipe when plotting

[lukasbrunner]

Description

Rename two parameter keys in the recipe to fix a bug in plotting as described in #2224.

• Closes Bug in ploting routines for ClimWIP test recipes #2224

---

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully
• 🧪 Recipe is well documented
• 🧪 Figure(s) and data look as expected from literature
• 🛠 Provenance information has been added

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[lukasbrunner]

Hoi @zklaus @bouweandela ! My go-to reviewer @ruthlorenz is currently on vacation so I hope you can have a quick look at this. It should fix the problems that @bouweandela found in #2198 (minus the missing models...)

[bouweandela]

@esmvalbot Please run recipe_climwip_brunner2019_med.yml

[esmvalbot]

Since @bouweandela asked, ESMValBot will run recipe recipe_climwip_brunner2019_med.yml as soon as possible, output will be generated here

[Peter9192]

For the other PRs, you added some settings here. Are they not needed for in this case?

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_climwip_brunner2019_med.yml: exit is null, output has been generated here

[bouweandela]

@esmvalbot Please run recipe_climwip_brunner2019_med.yml

[esmvalbot]

Since @bouweandela asked, ESMValBot will run recipe recipe_climwip_brunner2019_med.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_climwip_brunner2019_med.yml: exit is 1, output has been generated here

[Peter9192]

The bot failed because of missing data and a missing shapefile.

@bouweandela do you think it is possible to make the bot find some shape files? This one seems quite relevant for climate, so perhaps it could even serve as a 'standard' shape file for testing recipes.

[bouweandela]

@esmvalbot Please run recipe_climwip_brunner2019_med.yml

[esmvalbot]

Since @bouweandela asked, ESMValBot will run recipe recipe_climwip_brunner2019_med.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_climwip_brunner2019_med.yml: exit is 1, output has been generated here

[bouweandela]

I fixed the configuration of the bot so it finds the shapefile, but unfortunately a lot of the required climate model data is not available either on Mistral.

[lukasbrunner]

For this recipe (unlike for the testing cases addressed in #2225 & #2227) I can not really change the models as we are trying to re-create a published study with it. So what is the suggested solution here?

[bouweandela]

I think that the best solution would be if we ask for the additional data to be added: https://www.dkrz.de/up/services/data-management/cmip-data-pool. I'm on holiday this week, but i can look into that next week, or maybe @Peter9192 could do it?

[Peter9192]

I've put in a request for the following datasets:

- {short_name: [tas, pr, rsds, rlds, rsus], dataset: MRI-ESM1, project: CMIP5, exp: rcp85, ensemble: r1i1p1}
- {short_name: [tas, rsds], dataset: GISS-E2-R, project: CMIP5, exp: rcp85, ensemble: r2i1p1}
- {short_name: [pr, rsds], dataset: GISS-E2-R, project: CMIP5, exp: rcp85, ensemble: r2i1p3}
- {short_name: rlds, dataset: CCSM4, project: CMIP5, exp: rcp85, ensemble: r1i1p1}

hope I didn't miss one.

[zklaus]

Great, thanks, @Peter9192 !

[bouweandela]

@Peter9192 Did you ever get a response?

[Peter9192]

No, haven't heard anything..

[zklaus]

Since mistral is not responsive, shall we rely on local running as a means of confirmation? In that case, what is still open?

[bouweandela]

In that case, what is still open?

A review, maybe @ruthlorenz is back from holiday and could have a look?

[ruthlorenz]

Yes I can have a look! Will do later today or tomorrow....
Regarding the missing data this might be something to be discussed together with the testing strategy?

[bouweandela]

Hopefully the missing data problem will disappear once ESMValGroup/ESMValCore#1217 has been merged and is available in v2.4 of the ESMValCore.

[ruthlorenz]

I tried to run with ESMValTool v2.3
for some reason it crashes in weighted_temperature_graph (which seems to be unrelated to the changes in here....)
main_log.txt
log.txt

the map works and looks fine.
@lukasbrunner is it up to date with main or is it possible that given that this took so long (sorry.....) that it needs to be updated with main?

[lukasbrunner]

Thanks for the test @ruthlorenz! I've merged main into the branch and fixed the bug in the plotting script that created. It runs for me now with everything up to date. Can you try again please?

[ruthlorenz]

Looks good to me and works perfectly fine now!

[bouweandela]

Has the documentation of the recipe been updated? I didn't see the new settings of the diagnostic script mentioned here: https://docs.esmvaltool.org/en/latest/recipes/recipe_climwip.html

[lukasbrunner]

Hi @bouweandela could you specify which settings you are missing? The documentation should be under 'User settings in recipe' generally and under 'Updating the Brunner et al. (2019) recipe for new regions' specifically for this recipe.

[bouweandela]

The settings that are added to the recipe in this pull request: according to the documentation, diagnostic script weighted_temperature_graph.py only takes the arguments ancestors and weights, yet in this pull request an additional settings map containing several keys (central_estimate, lower_bound, start_year, etc) is given to this diagnostic script.