Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model AWI-CM-1-1-MR from recipe_impact.yml #2238

Merged
merged 1 commit into from Jul 20, 2021

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 19, 2021

Description

Recipe recipe_impact.yml fails to run with the latest release of ESMValCore (v2.3.0), see #2198 (comment), because the CMOR check for the AWI-CM-1-1-MR model fails, see ESMValGroup/ESMValCore#751. I suspect the CMOR check failure is for the areacello cell measure, which probably shouldn't be added to air_temperature for the area_statistics preprocessor anyway, because it is on a different grid. This pull request works around the problem by removing the AWI dataset from the recipe.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@bouweandela
Copy link
Member Author

@esmvalbot Please run recipe_impact.yml

@esmvalbot
Copy link

esmvalbot bot commented Jul 19, 2021

Since @bouweandela asked, ESMValBot will run recipe recipe_impact.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Jul 19, 2021

ESMValBot is happy to report recipe recipe_impact.yml ran OK, output has been generated here

@bouweandela bouweandela marked this pull request as ready for review July 20, 2021 07:03
@bouweandela bouweandela changed the title Update impact recipe Remove model AWI-CM-1-1-MR from recipe_impact.yml Jul 20, 2021
@bouweandela bouweandela requested a review from zklaus July 20, 2021 07:20
Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bouwe,
This workaround is fine at this stage πŸ‘

@bouweandela bouweandela merged commit 1c2bbd2 into main Jul 20, 2021
@bouweandela bouweandela deleted the recipe_impact_mistral branch July 20, 2021 07:28
@zklaus
Copy link
Contributor

zklaus commented Jul 20, 2021

People tend not to like models being removed, so maybe we should add an issue to re-add the model soon.

I also wonder: Do we really get areacello added to an atmosphere variable? If so, that seems like a bug worthy of its own issue as well.

@zklaus
Copy link
Contributor

zklaus commented Jul 20, 2021

For future reference, also note #2198 (comment)

@bouweandela
Copy link
Member Author

I also wonder: Do we really get areacello added to an atmosphere variable? If so, that seems like a bug worthy of its own issue as well.

Issue created: ESMValGroup/ESMValCore#1265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants