Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed recipe_meehl20sciadv.yml for ESMValCore 2.3 #2253

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Aug 5, 2021

This PR fixes recipe_meehl20sciadv.yml by adding a missing fx_variables: areacella.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added the bug label Aug 5, 2021
@schlunma schlunma added this to the v2.4.0 milestone Aug 5, 2021
@schlunma schlunma self-assigned this Aug 5, 2021
@schlunma
Copy link
Contributor Author

schlunma commented Aug 5, 2021

@esmvalbot Please run recipe_meehl20sciadv.yml

@esmvalbot
Copy link

esmvalbot bot commented Aug 5, 2021

Since @schlunma asked, ESMValBot will run recipe recipe_meehl20sciadv.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Aug 5, 2021

ESMValBot is happy to report recipe recipe_meehl20sciadv.yml ran OK, output has been generated here

@schlunma schlunma marked this pull request as ready for review August 5, 2021 14:04
@schlunma
Copy link
Contributor Author

schlunma commented Aug 5, 2021

@ESMValGroup/esmvaltool-coreteam can someone please quickly review and merge this? This adds 2 lines to recipe_meehl20sciadv.yml to fix it (it previously failed, see #2198). The bot ran fine πŸŽ‰

Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine, output looks comparable to cited paper - all good!

@bettina-gier bettina-gier merged commit e940528 into main Aug 5, 2021
@bettina-gier bettina-gier deleted the fix_meehl20sciadv branch August 5, 2021 14:18
@schlunma
Copy link
Contributor Author

schlunma commented Aug 5, 2021

Thanks Tina!!

@bouweandela
Copy link
Member

Good find @schlunma! I noticed that many more recipes are affected by this and opened issue ESMValGroup/ESMValCore#1265 to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants