Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full use of mamba in Github Actions source install test and use generic Python 3.7 (removing the very specific 3.7.10) #2287

Merged
merged 7 commits into from
Oct 7, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Sep 7, 2021

Description

This PR does two things:

  • experimental full use of mamba in the source install test
  • and revert to the more general Python 3.7 (instead of the specific 3.7.10)

I will generalize the full use of mamba to all the other tests once we've agreed fully that mamba's the way forward, for now it is used in a very user-centric test, the installation from source, and I'll look at this over a period of time, if it works fine then we're all in mamba business 馃悕

The source install test is super fast with mamba: Python 3.8 env done in 7min compared to 27min with conda and 3.9 is much faster too, see the conda test


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

@valeriupredoi valeriupredoi changed the title Full use of mamba in Github Actions source install test and remove all tests with Python 3.7 Full use of mamba in Github Actions source install test and use generic Python 3.7 (removing the very specific 3.7.10) Oct 7, 2021
@valeriupredoi
Copy link
Contributor Author

@zklaus it would be nice if we plugged this in 2.4 so we can have GA tests fully mambafied 馃悕

@zklaus zklaus added this to the v2.4.0 milestone Oct 7, 2021
@zklaus
Copy link
Contributor

zklaus commented Oct 7, 2021

I like it. Generally, feel free, nay encouraged, to assign any milestone you deem appropriate.

Once the branch is removed from the config file I'll approve and merge.

@valeriupredoi
Copy link
Contributor Author

sounds good, mi amigo! I removed them and even changed test titles to match what we have in Core (more human -readable) 馃嵑

@zklaus zklaus merged commit 8d570d5 into main Oct 7, 2021
@zklaus zklaus deleted the mamba_in_GA branch October 7, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants