Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed write_plots and write_netcdf from some NCL diagnostics #2293

Merged
merged 1 commit into from Sep 10, 2021

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Sep 8, 2021

This PR removes the write_plots and write_netcdf options (that will be removed in v2.4) from many NCL that would crash without them. I tested all affected recipes successfully.

It also adds an exception to the automatic addition of plot_file to the provenance entry when plot_file == "n/a" (which is used by some NCL diagnostics).


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number of pull requests:

@schlunma schlunma self-assigned this Sep 8, 2021
@schlunma schlunma added this to the v2.4.0 milestone Sep 8, 2021
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouweandela bouweandela merged commit f587cd3 into main Sep 10, 2021
@bouweandela bouweandela deleted the update_ncl_diags branch September 10, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants