Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add bounds to plev (plev19) in era interim cmorizer #2328

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 4, 2021

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated data reformatting script


To help with the number of pull requests:

@valeriupredoi
Copy link
Contributor Author

cheers @zklaus - can we wait to merge until @remi-kazeroni has had a look too, please? I reckon a data regeneration would be in store too 🍺

@remi-kazeroni
Copy link
Contributor

I reckon a data regeneration would be in store too 🍺

Good point @valeriupredoi πŸ‘ I'll have a look into this tomorrow at the latest

@valeriupredoi
Copy link
Contributor Author

take your time, man! The isenes3 plenary is not helping 😁

@zklaus
Copy link
Contributor

zklaus commented Oct 4, 2021

Well, I completely understand the constraints and limitations, but this has implications for the core, which is supposed to be frozen today, so if possible, looking at it sooner rather than later would be great.

@valeriupredoi
Copy link
Contributor Author

@zklaus - indeed, but given we don't need to change anything in Core perse, we should be fine. Good luck chairing the upcoming session at the plenary you two, I be there 🍺

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and this generates data without plev bounds as expected. But we have more than 300 GB of ERA-Interim data on Mistral, a large fraction of which has plev coordinates. So I'd rather be sure with need to regenerate the data before doing so.

@zklaus
Copy link
Contributor

zklaus commented Oct 5, 2021

If we are unsure about this, or just need something that is effective more quickly, we might consider adding a fix for ERA-Interim that simply removes the bounds in the preprocessor.

@valeriupredoi
Copy link
Contributor Author

@remi-kazeroni whoa! Yeah, prob best to be 100% sure about that - we'd kill Thor knows how many polar bears with that massive data movement 😁 I unfortunately don't now about the validity of not guessing bounds on ERA from a scientific point, up to you guys to know this πŸ‘

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, thanks. If that is fine, I will merge this myself once the new data are in place at Mistral and Jasmin

@remi-kazeroni remi-kazeroni merged commit 6d235ef into main Oct 19, 2021
@remi-kazeroni remi-kazeroni deleted the remove_plev_bounds_adding_era-interim branch October 19, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERA-Interim cmorizer puts bounds on plev coordinate
3 participants