Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'write_plots' from all NCL diagnostics #2331

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented Oct 6, 2021

This pr removes the deprecated feature "write_plots" from all NCL diagnostics that were still using this flag. This pr has been opened in response to issue #2005.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked to the best of my abilities. If you, @LisaBock want to review anyways, please do; I will nevertheless go ahead with the merge since this is rather technical.

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

Thanks, @axel-lauer for taking care of this! For the future, we generally expect authors to complete the checklist at the top of the PR prior to the review.

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot, please run bock20jgr/recipe_bock20jgr_fig_1-4.yml

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_1-4.yml
@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_8-10.yml
@esmvalbot Please run recipe_clouds_bias.yml
@esmvalbot Please run recipe_clouds_ipcc.yml
@esmvalbot Please run recipe_collins13ipcc.yml
@esmvalbot Please run recipe_flato13ipcc.yml
@esmvalbot Please run recipe_lauer13jclim.yml
@esmvalbot Please run recipe_seaice.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Sorry, ESMValBot can not find bock20jgr/recipe_bock20jgr_fig_1-4.yml
@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_8-10.yml
@esmvalbot Please run recipe_clouds_bias.yml
@esmvalbot Please run recipe_clouds_ipcc.yml
@esmvalbot Please run recipe_collins13ipcc.yml
@esmvalbot Please run recipe_flato13ipcc.yml
@esmvalbot Please run recipe_lauer13jclim.yml
@esmvalbot Please run recipe_seaice.yml recipe in ESMValGroup/ESMValTool repo at remove_write_netcdf_plots_ncl branch, please check that recipe name is correct

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_1-4.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Since @zklaus asked, ESMValBot will run recipe bock20jgr/recipe_bock20jgr_fig_1-4.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run bock20jgr/recipe_bock20jgr_fig_8-10.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Since @zklaus asked, ESMValBot will run recipe bock20jgr/recipe_bock20jgr_fig_8-10.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run recipe_clouds_bias.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_clouds_bias.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run recipe_clouds_ipcc.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_clouds_ipcc.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run recipe_collins13ipcc.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_collins13ipcc.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run recipe_flato13ipcc.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_flato13ipcc.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run recipe_lauer13jclim.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_lauer13jclim.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

@esmvalbot Please run recipe_seaice.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_seaice.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 21, 2021

The only failing tests are missing titles in recipes.

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

ESMValBot is sorry to report it failed to run recipe bock20jgr/recipe_bock20jgr_fig_1-4.yml: exit is 1, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

ESMValBot is sorry to report it failed to run recipe bock20jgr/recipe_bock20jgr_fig_8-10.yml: exit is 255, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

ESMValBot is sorry to report it failed to run recipe recipe_clouds_bias.yml: exit is 255, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

ESMValBot is sorry to report it failed to run recipe recipe_clouds_ipcc.yml: exit is 255, output has been generated here

@remi-kazeroni
Copy link
Contributor

I'm stopping the runs triggered here because the runtime of these recipes is quite long and makes the bot unavailable for other PRs which need quick runs. I'm happy to restart these runs at the end of the day.

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

ESMValBot is sorry to report it failed to run recipe recipe_collins13ipcc.yml: exit is 1, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

ESMValBot is sorry to report it failed to run recipe recipe_flato13ipcc.yml: exit is 1, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

ESMValBot is sorry to report it failed to run recipe recipe_lauer13jclim.yml: exit is 1, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 21, 2021

ESMValBot is sorry to report it failed to run recipe recipe_seaice.yml: exit is 1, output has been generated here

@zklaus zklaus merged commit bc3af4e into main Oct 22, 2021
@zklaus zklaus deleted the remove_write_netcdf_plots_ncl branch October 22, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants