Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added titles to recipes maintained by lauer_axel #2332

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented Oct 6, 2021

This PR adds titles to all recipes maintained by myself. This is in response to issue #2324.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@zklaus
Copy link
Contributor

zklaus commented Oct 6, 2021

Great, @axel-lauer, thanks! Could you please go through the check-list and let us know when this is ready for review?

@axel-lauer
Copy link
Contributor Author

Check the appropriate boxes. I think in this case, a technical review only would be fine. This PR is ready for review.

@zklaus
Copy link
Contributor

zklaus commented Oct 6, 2021

If possible, perhaps a look by a fellow scientist would also be good. For example, I stumbled on "surface temperature" vs "near-surface temperature" thinking of skin and soil temperature etc.

@ruthlorenz, perhaps you could have a look?

@zklaus
Copy link
Contributor

zklaus commented Oct 6, 2021

Technically, this looks good 馃憤

@zklaus
Copy link
Contributor

zklaus commented Oct 6, 2021

@esmvalbot Please run recipe_bock20jgr.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_bock20jgr.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 6, 2021

@esmvalbot Please run recipe_clouds_bias.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_clouds_bias.yml as soon as possible, output will be generated here

@zklaus
Copy link
Contributor

zklaus commented Oct 6, 2021

@esmvalbot Please run recipe_clouds_ipcc.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_clouds_ipcc.yml as soon as possible, output will be generated here

@axel-lauer
Copy link
Contributor Author

Surface temperature is often (even though slightly imprecise) used for near-surface temperature. I understand that these are titles only, i.e. something short. In my opinion, a scientifically fully correct and precise description would be too long. This would be rather the puropose of a figure caption.

@zklaus
Copy link
Contributor

zklaus commented Oct 6, 2021

My point was not that this one necessary needs to be changed, but rather that it's good to have a second pair of eyes look these over.

@zklaus
Copy link
Contributor

zklaus commented Oct 6, 2021

@esmvalbot Please run recipe_ecs_scatter.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_ecs_scatter.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2021

ESMValBot is sorry to report it failed to run recipe recipe_bock20jgr.yml: exit is 1, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2021

ESMValBot is sorry to report it failed to run recipe recipe_clouds_bias.yml: exit is 1, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2021

ESMValBot is sorry to report it failed to run recipe recipe_clouds_ipcc.yml: exit is 1, output has been generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 6, 2021

ESMValBot is sorry to report it failed to run recipe recipe_ecs_scatter.yml: exit is 1, output has been generated here

@zklaus zklaus added this to the v2.4.0 milestone Oct 7, 2021
@valeriupredoi
Copy link
Contributor

nice! (not the Bot, which appears to be inebriated) but the PR. So are we all adding titles to own recipes now - or there will be someone called Dredd who will add all the titles in one PR? 馃榿

@zklaus
Copy link
Contributor

zklaus commented Oct 7, 2021

nice! (not the Bot, which appears to be inebriated) but the PR. So are we all adding titles to own recipes now - or there will be someone called Dredd who will add all the titles in one PR? grin

See #2324 (comment)

@valeriupredoi
Copy link
Contributor

nice! (not the Bot, which appears to be inebriated) but the PR. So are we all adding titles to own recipes now - or there will be someone called Dredd who will add all the titles in one PR? grin

See #2324 (comment)

gotcha! Cheers, K-man!

@bouweandela
Copy link
Member

@esmvalbot Please run recipe_ecs_scatter.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 8, 2021

Since @bouweandela asked, ESMValBot will run recipe recipe_ecs_scatter.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Oct 8, 2021

ESMValBot is sorry to report it failed to run recipe recipe_ecs_scatter.yml: exit is 1, output has been generated here

@valeriupredoi
Copy link
Contributor

@esmvalbot get a grip on yourself, mate 馃憡

@bouweandela
Copy link
Member

I think this can be merged without testing, because we're going to test all recipes for the release anyway.

@axel-lauer Could you have a look at the merge conflict?

@bouweandela bouweandela merged commit dc3ee1f into main Oct 15, 2021
@bouweandela bouweandela deleted the adding_titles_to_recipes branch October 15, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants