Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titles to recipes authored by predoi_valeriu #2333

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 7, 2021

Description

Adding titles to all the recipe authored by me. Also adding @alistairsellar as author to all the other Autoassess recipes which he was not an author of, since that's his work there too (historical/Met Office, but still work 馃榿 ). Ali man, you mind having a look at the titles and suggest any better ones if you think they need them, please? I am just an engineer and don't really know what's the best title for them sciency Autoassess recipes 馃嵑


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

New or updated recipe/diagnostic

@zklaus
Copy link
Contributor

zklaus commented Oct 8, 2021

@alistairsellar, could you have a quick look at the titles here to determine if they make sense?

@valeriupredoi valeriupredoi mentioned this pull request Oct 8, 2021
6 tasks
@@ -12,6 +12,10 @@ documentation:
authors:
- predoi_valeriu

titile: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: titile -> title
(a few examples below also)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, things I wish I had 馃ぃ

@@ -11,6 +11,9 @@ documentation:

authors:
- predoi_valeriu
- sellar_alistair

titile: Land-surface assessment area diagnostic that computes permafrost (from Autoassess).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest "computes permafrost indices", for consistency with stratosphere below. Perhaps delete "assessment area" to shorten the title.

@@ -10,6 +10,9 @@ documentation:

authors:
- predoi_valeriu
- sellar_alistair

titile: Land-surface assessment area diagnostic that computes soilmoisture (from Autoassess).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, "computes soil moisture indices".

@alistairsellar
Copy link
Contributor

Overall looks good to me. I've suggested a couple of tweaks in my review.

@zklaus zklaus added this to the v2.4.0 milestone Oct 11, 2021
@valeriupredoi
Copy link
Contributor Author

@alistairsellar many thanks, mate 馃嵑 I shall plug the changes in a jiffy!

@alistairsellar
Copy link
Contributor

All looks good to me V!

@valeriupredoi
Copy link
Contributor Author

cheers @alistairsellar for le review 馃嵑

@valeriupredoi valeriupredoi merged commit 224d4e1 into main Oct 11, 2021
@valeriupredoi valeriupredoi deleted the add_titles_autoassess_recipes branch October 11, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants