Add titles to recipes authored by predoi_valeriu#2333
Merged
Conversation
zklaus
approved these changes
Oct 8, 2021
zklaus
added
approved by technical reviewer
and removed
looking for technical reviewer
labels
Contributor
|
@alistairsellar, could you have a quick look at the titles here to determine if they make sense? |
alistairsellar
requested changes
Oct 11, 2021
| authors: | ||
| - predoi_valeriu | ||
|
|
||
| titile: | |
Contributor
There was a problem hiding this comment.
Typo: titile -> title
(a few examples below also)
Contributor
Author
There was a problem hiding this comment.
ah yes, things I wish I had 🤣
| - predoi_valeriu | ||
| - sellar_alistair | ||
|
|
||
| titile: Land-surface assessment area diagnostic that computes permafrost (from Autoassess). |
Contributor
There was a problem hiding this comment.
I suggest "computes permafrost indices", for consistency with stratosphere below. Perhaps delete "assessment area" to shorten the title.
| - predoi_valeriu | ||
| - sellar_alistair | ||
|
|
||
| titile: Land-surface assessment area diagnostic that computes soilmoisture (from Autoassess). |
Contributor
There was a problem hiding this comment.
As above, "computes soil moisture indices".
Contributor
|
Overall looks good to me. I've suggested a couple of tweaks in my review. |
Contributor
Author
|
@alistairsellar many thanks, mate 🍺 I shall plug the changes in a jiffy! |
alistairsellar
approved these changes
Oct 11, 2021
Contributor
|
All looks good to me V! |
Contributor
Author
|
cheers @alistairsellar for le review 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding titles to all the recipe authored by me. Also adding @alistairsellar as author to all the other Autoassess recipes which he was not an author of, since that's his work there too (historical/Met Office, but still work 😁 ). Ali man, you mind having a look at the titles and suggest any better ones if you think they need them, please? I am just an engineer and don't really know what's the best title for them sciency Autoassess recipes 🍺
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic