GlobWat fix download links and gdal command #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-kazeroni
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Thank you for fixing the documentation @babdollahi. This works fine for me now. I took the liberty to add a label (needed for the changelogs) and cross out the unrelevant parts of the check list with ~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hydrology/recipe_globwat.yml#2261Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
- [ ] 🧪 Recipe runs successfully- [ ] 🧪 Recipe is well documented- [ ] 🧪 Figure(s) and data look as expected from literature- [ ] 🛠 Provenance information has been addedNew or updated data reformatting script
- [ ] 🛠 Documentation is available- [ ] 🛠 The dataset has been added to the CMOR check recipe- [ ] 🧪 Numbers and units of the data look physically meaningfulTo help with the number of pull requests: