Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation instructions for Julia #2335

Merged
merged 4 commits into from Oct 29, 2021
Merged

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Oct 8, 2021

Description

This cleans up the installation of Julia to use the conda-forge build which should help with binary compatibility in the environment and thus address (parts of) the following issues:

Closes #2303


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.


To help with the number of pull requests:

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 11, 2021

very nice dude, I likes 馃榿 You wanna merge/merge with changes #2236 in here and close that so we have one PR to rule them all? Oh and #2237 too

@zklaus
Copy link
Contributor Author

zklaus commented Oct 11, 2021

Cheers @valeriupredoi. Those need sorting out. I did not start this PR with the intention of moving to mamba here, but it turned out conda was too slow, so I went there just to see the tests.

Perhaps we can simply first get #2236 and #2237 in and rebase this one on top of those? Anyway, I decided to focus on ESMValCore for now to get the release out the door there and then turn to these issues again.

@valeriupredoi
Copy link
Contributor

whatever you reckon it's best, man, I has no preferences as long as mamba gets in the room 馃榿

@zklaus zklaus force-pushed the fix-installation-instructions branch from 2881073 to fc95cb1 Compare October 29, 2021 09:24
@zklaus zklaus marked this pull request as ready for review October 29, 2021 09:24
@zklaus zklaus marked this pull request as draft October 29, 2021 09:25
@zklaus zklaus changed the title Fix installation instructions Fix installation instructions for Julia Oct 29, 2021
@zklaus zklaus marked this pull request as ready for review October 29, 2021 09:31
@@ -17,6 +17,7 @@ dependencies:
# Non-Python dependencies
- cdo
- imagemagick
- julia
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait - am confused now: you tell users to install Julia with conda install julia but you are also including Julia as a conda dependency here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the environment will install Julia, not the conda-forge package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah gothcha! Ok makes sense 馃嵑

@valeriupredoi
Copy link
Contributor

very nice PR, man! But am a bit confused about the way the users get told to install Julia when it's already in the esmvaltool environment?

@valeriupredoi
Copy link
Contributor

we should also close #2361 after this gets merged

@valeriupredoi
Copy link
Contributor

another thing (yeh sorry, am verbose today) - this actually closes the issue with the Julia recipe not working #2303 - not sure about the other but I suspect that this will also close that one too, Julia is pretty stable installed from conda-forge

@zklaus zklaus merged commit 09d07d8 into main Oct 29, 2021
@zklaus zklaus deleted the fix-installation-instructions branch October 29, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example recipe examples/recipe_julia.yml fails
2 participants