Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example recipes #2338

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Fix example recipes #2338

merged 3 commits into from
Oct 8, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 8, 2021

Description

I am fixing the example recipes here: most of them just need titles, but the preprocessor_test one needed a bit more work done, I did the following to it:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

request.
-->

@valeriupredoi
Copy link
Contributor Author

that was the fastest approval in the history of PR's @zklaus 😆 I need to add moar titles to the remainder of the examples recipes, and then will fix the the boxes then merge, but I needs lunch now 🍔

@zklaus
Copy link
Contributor

zklaus commented Oct 8, 2021

Lunch? You mean dinner. 🇸🇪 Anyway, if it's not ready yet, best to keep it a draft PR.

@zklaus zklaus marked this pull request as draft October 8, 2021 14:18
@valeriupredoi
Copy link
Contributor Author

yeps, cheers! will de-Draftify after lunch, ahem, dinner 🇸🇪

@valeriupredoi valeriupredoi marked this pull request as ready for review October 8, 2021 16:02
@valeriupredoi valeriupredoi merged commit 569c188 into main Oct 8, 2021
@valeriupredoi valeriupredoi deleted the fix_example_recipes branch October 8, 2021 16:27
@@ -5,6 +5,8 @@ documentation:
description: |
Recipe for example diagnostic written in Julia.

title: Recipe running an example diagnostic written in Julia Roberts.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the work of Julia Roberts, perhaps Julia Child may be more appropriate for testing recipes. On second thought you probably just mean Julia, the language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, I'll exclude Julia Roberts from the cast 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in multimodel cube merge surfaced by running recipe_preprocessor_test.yml
3 participants