Fix example recipes#2338
Merged
valeriupredoi merged 3 commits intomainfrom Oct 8, 2021
Merged
Conversation
zklaus
approved these changes
Oct 8, 2021
Contributor
Author
|
that was the fastest approval in the history of PR's @zklaus 😆 I need to add moar titles to the remainder of the examples recipes, and then will fix the the boxes then merge, but I needs lunch now 🍔 |
Contributor
|
Lunch? You mean dinner. 🇸🇪 Anyway, if it's not ready yet, best to keep it a draft PR. |
Contributor
Author
|
yeps, cheers! will de-Draftify after lunch, ahem, dinner 🇸🇪 |
…ch is in another PR)
mkitti
reviewed
Nov 29, 2021
| description: | | ||
| Recipe for example diagnostic written in Julia. | ||
|
|
||
| title: Recipe running an example diagnostic written in Julia Roberts. |
There was a problem hiding this comment.
While I appreciate the work of Julia Roberts, perhaps Julia Child may be more appropriate for testing recipes. On second thought you probably just mean Julia, the language.
Contributor
Author
There was a problem hiding this comment.
cheers, I'll exclude Julia Roberts from the cast 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am fixing the example recipes here: most of them just need titles, but the
preprocessor_testone needed a bit more work done, I did the following to it:recipe_preprocessor_test.ymlESMValCore#1339 - note that all other functionality is preservedmyPersonal_diagnosticrecipe since I set a title for that one in Add titles to recipes authored bypredoi_valeriu#2333 (avoiding git conflicts)recipe_preprocessor_test.ymlESMValCore#1339Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
request.
-->