Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mpich from conda dependencies list #2343

Merged
merged 6 commits into from
Oct 12, 2021
Merged

Remove mpich from conda dependencies list #2343

merged 6 commits into from
Oct 12, 2021

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 11, 2021

Description

Unpinning mpich to free. Tested locally and the env builds well with

(unpin_mpich) valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ conda list mpich
# packages in environment at /home/valeriu/miniconda3/envs/unpin_mpich:
#
# Name                    Version                   Build  Channel
mpich                     3.4.2              h846660c_100    conda-forge

so there is not even the need to have it > 3.4.1.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

@zklaus
Copy link
Contributor

zklaus commented Oct 11, 2021

Why don't we remove mpich from the dependencies completely?

@valeriupredoi
Copy link
Contributor Author

that's a very good question - I think it was in before, but I can't remember as to why. Lemme do a test!

@zklaus
Copy link
Contributor

zklaus commented Oct 11, 2021

Test away! If you want to know if it actually was in before, use blame.

@valeriupredoi
Copy link
Contributor Author

did a test, all goes fine, just running a GA test too to be extra safers πŸ‘

@valeriupredoi valeriupredoi changed the title Unpin mpich to free Remove mpich from conda dependencies list Oct 11, 2021
@valeriupredoi
Copy link
Contributor Author

@zklaus all's done and tested from me side, mate πŸ‘

@zklaus zklaus merged commit 867d8d1 into main Oct 12, 2021
@zklaus zklaus deleted the unpin_mpich branch October 12, 2021 11:41
zklaus added a commit that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mpich pinning for conda
2 participants